-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move namespace selector #5250
Move namespace selector #5250
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What do you think about removing the separator before "Custom Resource Definitions"? |
Depends, to which section it belongs in K8S API docs? |
To the cluster section. However, for us it should be a section on its own as we are displaying the pinned CRDs below. |
8a21421
to
9929aa9
Compare
9929aa9
to
b99b8ff
Compare
fe22fa5
to
0679cca
Compare
Codecov Report
@@ Coverage Diff @@
## master #5250 +/- ##
==========================================
- Coverage 45.53% 45.42% -0.12%
==========================================
Files 214 214
Lines 10117 10208 +91
Branches 107 108 +1
==========================================
+ Hits 4607 4637 +30
- Misses 5239 5298 +59
- Partials 271 273 +2
Continue to review full report at Codecov.
|
As we want to introduce more resources (SA, Roles, etc.) it would cause confusion if we'd add non-namespaced resources under namespace selector or have 2 cluster sections for namespaced and non-namespaced resources. We've decided to move the selector to the top bar and add small indicators to show which sections/resources are namespaced and will be influenced by the namespace change.
Additionally, I have updated
Discovery and Load Balancing
section toService
as this is how it's called now in the k8s docs.https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#-strong-service-apis-strong-
This is how it looks like