Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format; "=>' #532

Merged
merged 1 commit into from
Mar 15, 2016
Merged

Fix format; "=>' #532

merged 1 commit into from
Mar 15, 2016

Conversation

f-higashi
Copy link
Contributor

clang-format updated to v1.0.36 which checks double quotation.

https://travis-ci.org/kubernetes/dashboard/builds/116048772


This change is Reviewable

clang-format updated to v1.0.36 which checks double quotation.
@codecov-io
Copy link

Current coverage is 85.99%

Merging #532 into master will not affect coverage as of 9b7b4e6

@@            master    #532   diff @@
======================================
  Files           95      95       
  Stmts          814     814       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            700     700       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 9b7b4e6

Powered by Codecov. Updated on successful CI builds.

@cheld
Copy link
Contributor

cheld commented Mar 15, 2016

Thanks, nice - kind of....So, clang was updated to minor version 1.0.36 (because we use ~ in package.json). As a result our build broke and you fixed it, right? Hmm, what about Greenkeeper? If we would have specified a specific version, than Greenkeeper would have tested and suggested the update, right?

Anyway, result is nice

@f-higashi
Copy link
Contributor Author

As a result our build broke and you fixed it, right?

yes.

Currently, we specifies gulp-clang-format which depends on clang-format and does not update recently.
In this case, Greenkeeper does not work maybe.

@floreks
Copy link
Member

floreks commented Mar 15, 2016

For me npm still downloads old version of gulp-clang-format. Even if I delete it still 1.0.23 is downloaded. Did you change the configuration? I'm using npm 3.8.0

@floreks
Copy link
Member

floreks commented Mar 15, 2016

I've cleared cache and removed all clang-format dependencies. New version is downloaded. My mistake :)

@floreks
Copy link
Member

floreks commented Mar 15, 2016

:lgtm:


Reviewed 22 of 22 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

floreks pushed a commit that referenced this pull request Mar 15, 2016
Fix double quote format to single quote because of clang-format update
@floreks floreks merged commit 69c453f into kubernetes:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants