Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move local settings from cookies to local storage #5529

Conversation

maciaszczykm
Copy link
Member

Fix #5528.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #5529 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5529      +/-   ##
==========================================
+ Coverage   43.60%   43.61%   +0.01%     
==========================================
  Files         171      171              
  Lines        9119     9119              
==========================================
+ Hits         3976     3977       +1     
+ Misses       4891     4890       -1     
  Partials      252      252              
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 90.90% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1578e8...d111c5a. Read the comment docs.

@maciaszczykm maciaszczykm changed the title Set local settings cookie expiry date to 14 days Move local settings from cookies to local storage Sep 10, 2020
@maciaszczykm maciaszczykm marked this pull request as draft September 10, 2020 12:40
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2020
@maciaszczykm maciaszczykm marked this pull request as ready for review September 10, 2020 14:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2020
@maciaszczykm maciaszczykm merged commit 1d9fe8e into kubernetes:master Sep 10, 2020
@maciaszczykm maciaszczykm deleted the fix/local-settings-cookie-expiration branch September 10, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localSettings cookie for kubernetes dashboard is a session cookie and does not persist when browser is closed.
2 participants