Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct ports #563

Merged
merged 1 commit into from
Mar 24, 2016
Merged

use the correct ports #563

merged 1 commit into from
Mar 24, 2016

Conversation

mdevilliers
Copy link
Contributor

Simple fix to align the ports in the readme with the k8s config for the dashboard


This change is Reviewable

@codecov-io
Copy link

Current coverage is 86.54%

Merging #563 into master will not affect coverage as of f0c4152

@@            master    #563   diff @@
======================================
  Files           97      97       
  Stmts          847     847       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            733     733       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of f0c4152

Powered by Codecov. Updated on successful CI builds.

@bryk
Copy link
Contributor

bryk commented Mar 24, 2016

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bryk bryk merged commit 58ffbaf into kubernetes:master Mar 24, 2016
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
Fixed error and success notifications not shown to user on deleting volume group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants