Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate metadata.annotation key from psp template in helm chart #6678

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

jdftapi
Copy link
Contributor

@jdftapi jdftapi commented Dec 28, 2021

In v5.0.5 of the helm chart included in this repository, the template for the podsecuritypolicy yaml template contains the metadata.annotation key two times, which leads to errors when trying to parse the yaml with some tools, e.g. flux2's helm-controller.

This commit will deduplicate the yaml key which should make it parseable again.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Dec 28, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 28, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 28, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @jdftapi!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 28, 2021
@jdftapi jdftapi changed the title removes duplicate metadata.annotation key from psp template in helm chart (fixes #6677) WIP: removes duplicate metadata.annotation key from psp template in helm chart (fixes #6677) Dec 28, 2021
@jdftapi jdftapi changed the title WIP: removes duplicate metadata.annotation key from psp template in helm chart (fixes #6677) WIP: removes duplicate metadata.annotation key from psp template in helm chart Dec 28, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 28, 2021
@jdftapi jdftapi changed the title WIP: removes duplicate metadata.annotation key from psp template in helm chart WIP: remove duplicate metadata.annotation key from psp template in helm chart Dec 28, 2021
@desaintmartin
Copy link
Member

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desaintmartin, jdftapi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@desaintmartin
Copy link
Member

Could you mark the PR as ready?

@jdftapi jdftapi marked this pull request as ready for review December 29, 2021 14:36
@jdftapi jdftapi changed the title WIP: remove duplicate metadata.annotation key from psp template in helm chart remove duplicate metadata.annotation key from psp template in helm chart Dec 29, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6c249bb into kubernetes:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants