-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed indent of selector.matchLabels in serviceMonitor #6750
Conversation
/assign @desaintmartin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you bump patch version of the chart?
Thanks for the review. This chart is forked based on the following version. version: 5.1.1
appVersion: 2.4.0 and Forked from What should I specify for the semantics version number? |
Yes ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin, fukuta-tatsuya-intec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm using 5.2.0 and still getting this error for some reason. |
I am using 5.2.1 and it still does not work. |
An error occurs when activating serviceMonitor as shown below.
The reason why this error occurs is that the number of indentations in selector.matchLabels is not specified correctly.
I have corrected this number in my PR. Please take care of it.