Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed indent of selector.matchLabels in serviceMonitor #6750

Merged
merged 2 commits into from Feb 2, 2022
Merged

Fixed indent of selector.matchLabels in serviceMonitor #6750

merged 2 commits into from Feb 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2022

An error occurs when activating serviceMonitor as shown below.

serviceMonitor:
  enabled: true
$ helm -n rdbox-systems install kubernetes-dashboard kubernetes-dashboard/kubernetes-dashboard -f values_for_k8s-dashboard.yaml
Error: INSTALLATION FAILED: YAML parse error on kubernetes-dashboard/templates/servicemonitor.yaml: error converting YAML to JSON: yaml: line 25: did not find expected key

The reason why this error occurs is that the number of indentations in selector.matchLabels is not specified correctly.
I have corrected this number in my PR. Please take care of it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2022
@ghost
Copy link
Author

ghost commented Feb 2, 2022

/assign @desaintmartin

Copy link
Member

@desaintmartin desaintmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you bump patch version of the chart?

@ghost
Copy link
Author

ghost commented Feb 2, 2022

@desaintmartin

Thanks for the review.

This chart is forked based on the following version.

version: 5.1.1
appVersion: 2.4.0

and Forked from
2d4c06b

What should I specify for the semantics version number?
(v5.1.2??)

@desaintmartin
Copy link
Member

Yes !

@ghost ghost requested a review from desaintmartin February 2, 2022 07:54
Copy link
Member

@desaintmartin desaintmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@desaintmartin
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desaintmartin, fukuta-tatsuya-intec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7ad0d43 into kubernetes:master Feb 2, 2022
@drunkirishcoder
Copy link
Contributor

I'm using 5.2.0 and still getting this error for some reason.

@ghost ghost mentioned this pull request Feb 21, 2022
@desaintmartin
Copy link
Member

I am using 5.2.1 and it still does not work.
I've created #6839 to add testing (and finally fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants