Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment files to support new architecture #7544

Merged
merged 125 commits into from
Jun 23, 2023

Conversation

floreks
Copy link
Member

@floreks floreks commented Nov 25, 2022

TBD

@floreks floreks self-assigned this Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@floreks floreks marked this pull request as draft November 25, 2022 13:41
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 25, 2022
README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #7544 (71775cb) into master (ce15290) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7544      +/-   ##
==========================================
- Coverage   42.19%   42.18%   -0.01%     
==========================================
  Files         218      218              
  Lines       12099    12099              
  Branches      179      179              
==========================================
- Hits         5105     5104       -1     
- Misses       6709     6710       +1     
  Partials      285      285              

charts/recommended.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@romdhanisam romdhanisam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can explain more about new architecture!

@marcosdiez
Copy link
Contributor

From what I understood,
the main dashboard container will be split into two:

one for the backend and one for the frontend.

the backend will receive /api/* ( or /api/v1/*)
the rest should go to the frontent

that means a router will be needed in front of it, so the setup will be more complex.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023
@floreks
Copy link
Member Author

floreks commented Feb 10, 2023

@romdhanisam

You can explain more about new architecture!

@marcosdiez is correct.

From what I understood, the main dashboard container will be split into two:

one for the backend and one for the frontend.

the backend will receive /api/* ( or /api/v1/*) the rest should go to the frontent

that means a router will be needed in front of it, so the setup will be more complex.

We will utilize cert-manager and ingress-nginx to expose dashboard by default on a localhost domain. Since API and Web UI are in separate containers now we are using Ingress as a gateway that connects them together. In the future, we will probably use a dedicated gateway to leverage API and merge multiple API services into a single API. cert-manager is used to allow HTTPS access as it can generate self-signed cert used by ingress controller to expose the application.

kind: Ingress
apiVersion: networking.k8s.io/v1
metadata:
  labels:
    k8s-app: kubernetes-dashboard
  annotations:
    nginx.ingress.kubernetes.io/ssl-redirect: "true"
    cert-manager.io/issuer: selfsigned
  name: kubernetes-dashboard
spec:
  ingressClassName: nginx
  tls:
  - hosts:
    - localhost
    secretName: kubernetes-dashboard-certs
  rules:
  - host: localhost
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: dashboard-web
            port:
              name: http
      - path: /api/v1
        pathType: Prefix
        backend:
          service:
            name: dashboard-api
            port:
              name: API

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2023
maciaszczykm and others added 20 commits June 23, 2023 12:21
…deployment

# Conflicts:
#	modules/web/i18n/de/messages.de.xlf
#	modules/web/i18n/es/messages.es.xlf
#	modules/web/i18n/fr/messages.fr.xlf
#	modules/web/i18n/ja/messages.ja.xlf
#	modules/web/i18n/ko/messages.ko.xlf
#	modules/web/i18n/messages.xlf
#	modules/web/i18n/zh-Hans/messages.zh-Hans.xlf
#	modules/web/i18n/zh-Hant-HK/messages.zh-Hant-HK.xlf
#	modules/web/i18n/zh-Hant/messages.zh-Hant.xlf
@maciaszczykm maciaszczykm marked this pull request as ready for review June 23, 2023 12:38
@maciaszczykm maciaszczykm changed the title [WIP] Update deployment files to support new architecture Update deployment files to support new architecture Jun 23, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2023
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maciaszczykm maciaszczykm merged commit abb9f0d into kubernetes:master Jun 23, 2023
@maciaszczykm maciaszczykm deleted the update/deployment branch June 23, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants