-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment files to support new architecture #7544
Conversation
floreks
commented
Nov 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #7544 +/- ##
==========================================
- Coverage 42.19% 42.18% -0.01%
==========================================
Files 218 218
Lines 12099 12099
Branches 179 179
==========================================
- Hits 5105 5104 -1
- Misses 6709 6710 +1
Partials 285 285 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can explain more about new architecture!
From what I understood, one for the backend and one for the frontend. the backend will receive /api/* ( or /api/v1/*) that means a router will be needed in front of it, so the setup will be more complex. |
@marcosdiez is correct.
We will utilize kind: Ingress
apiVersion: networking.k8s.io/v1
metadata:
labels:
k8s-app: kubernetes-dashboard
annotations:
nginx.ingress.kubernetes.io/ssl-redirect: "true"
cert-manager.io/issuer: selfsigned
name: kubernetes-dashboard
spec:
ingressClassName: nginx
tls:
- hosts:
- localhost
secretName: kubernetes-dashboard-certs
rules:
- host: localhost
http:
paths:
- path: /
pathType: Prefix
backend:
service:
name: dashboard-web
port:
name: http
- path: /api/v1
pathType: Prefix
backend:
service:
name: dashboard-api
port:
name: API |
…deployment # Conflicts: # modules/web/i18n/de/messages.de.xlf # modules/web/i18n/es/messages.es.xlf # modules/web/i18n/fr/messages.fr.xlf # modules/web/i18n/ja/messages.ja.xlf # modules/web/i18n/ko/messages.ko.xlf # modules/web/i18n/messages.xlf # modules/web/i18n/zh-Hans/messages.zh-Hans.xlf # modules/web/i18n/zh-Hant-HK/messages.zh-Hant-HK.xlf # modules/web/i18n/zh-Hant/messages.zh-Hant.xlf
… update/deployment
… update/deployment
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |