fix: escape the dialog should not trigger delete resource

[jenting]

Escape the delete resource dialog should not trigger delete resource.

[k8s-ci-robot]

Welcome @jenting!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jenting
Once this PR has been reviewed and has the lgtm label, please assign maciaszczykm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[floreks]

You are basically allowing undefined to be recognized as cancel. I think this should be fixed directly in the dialog to make it return cancelDelete as it should in the first place.

[jenting]

You are basically allowing undefined to be recognized as cancel. I think this should be fixed directly in the dialog to make it return cancelDelete as it should in the first place.

@floreks
Thanks for your feedback. I updated the code to handle escape event and backdrop clicks in the dialog to make it return cancelDelete. Let me know if it's better than before.

[jenting]

@floreks any chance to review this? Thanks.