Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): ssar resource kind name and resource updates #9599

Merged
merged 2 commits into from
Oct 27, 2024
Merged

fix(api): ssar resource kind name and resource updates #9599

merged 2 commits into from
Oct 27, 2024

Conversation

floreks
Copy link
Member

@floreks floreks commented Oct 27, 2024 •
edited
Loading

Fixes #9591
Fixes #9516

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2024
@floreks floreks added the kind/bug Categorizes issue or PR as related to a bug. label Oct 27, 2024
@floreks floreks self-assigned this Oct 27, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 35.88%. Comparing base (b6d4c4d) to head (15b082f).
Report is 17 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9599      +/-   ##
==========================================
- Coverage   35.93%   35.88%   -0.05%     
==========================================
  Files         301      301              
  Lines       14479    14501      +22     
  Branches      202      183      -19     
==========================================
+ Hits         5203     5204       +1     
- Misses       9052     9073      +21     
  Partials      224      224

@floreks floreks changed the title fix(api): ssar resource kind name invalid fix(api): ssar resource kind name and resource update Oct 27, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2024
@floreks floreks changed the title fix(api): ssar resource kind name and resource update fix(api): ssar resource kind name and resource updates Oct 27, 2024
@floreks floreks added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8c15a76 into master Oct 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@floreks @k8s-ci-robot