Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
  • Loading branch information
nabokihms and liggitt committed Jan 24, 2023
1 parent 4c6a711 commit 19e03f8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -254,18 +254,17 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1beta1` API
- Promote feature gate to Beta and make it enabled by default
- Unit tests coverage improved
- `kubectl alpha auth whoami` command uses `authentication.k8s.io/v1beta1` API
- `kubectl alpha auth whoami` command uses `authentication.k8s.io/v1beta1` API, falls back to `authentication.k8s.io/v1alpha1` API
- Fix [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#self-subject-review):
- Change API version
- Rewrite conditions to enable the feature

#### GA

- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1` API
- `SelfSubjectReview` is promoted to `authentication.k8s.io/v1` API and enable by default
- Promote feature gate to Stable
- `kubectl alpha auth whoami` replaced with `kubectl auth whoami`
- `kubectl auth whoami` command uses `authentication.k8s.io/v1` API
- An article about motivation to use this feature is added to the Kubernetes blog
- `kubectl auth whoami` command prefers `authentication.k8s.io/v1` API over `authentication.k8s.io/v1beta1` and `authentication.k8s.io/v1alpha1`
- More integration and e2e tests cases
- Fix [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#self-subject-review):
- Change API version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ reviewers:
- "@mikedanese"
- "@liggitt"
approvers:
- TBD
- "@deads2k"
- "@liggitt"
creation-date: "2022-05-30"
status: implementable
stage: alpha
stage: beta
latest-milestone: "v1.26"
milestone:
alpha: "v1.26"
Expand Down

0 comments on commit 19e03f8

Please sign in to comment.