Skip to content

Commit

Permalink
Merge pull request #2815 from ehashman/swap-feature-flag
Browse files Browse the repository at this point in the history
KEP-2400: Rename feature flag to NodeSwap
  • Loading branch information
k8s-ci-robot authored Aug 12, 2021
2 parents da16e6a + a771ea3 commit 59a1941
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions keps/sig-node/2400-node-swap/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ poses low risk to Kubernetes clusters that will not enable swap.

We summarize the implementation plan as following:

1. Add a feature gate `NodeSwapEnabled` to enable swap support.
1. Add a feature gate `NodeSwap` to enable swap support.
1. Leave the default value of kubelet flag `--fail-on-swap` to `true`, to avoid
changing default behaviour.
1. Introduce a new kubelet config parameter, `MemorySwap`, which configures how
Expand Down Expand Up @@ -336,7 +336,7 @@ type KubeletConfiguration struct {
metav1.TypeMeta
...
// Configure swap memory available to container workloads.
// +featureGate=NodeSwapEnabled
// +featureGate=NodeSwap
// +optional
MemorySwap MemorySwapConfiguration
}
Expand Down Expand Up @@ -513,7 +513,7 @@ Pick one of these and delete the rest.
-->

- [x] Feature gate (also fill in values in `kep.yaml`)
- Feature gate name: NodeSwapEnabled
- Feature gate name: NodeSwap
- Components depending on the feature gate: API Server, Kubelet
- [x] Other
- Describe the mechanism: `--fail-swap-on=false` flag for kubelet must also
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-node/2400-node-swap/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ milestone:
# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
feature-gates:
- name: NodeSwapEnabled
- name: NodeSwap
components:
- kube-apiserver
- kubelet
Expand Down

0 comments on commit 59a1941

Please sign in to comment.