Skip to content

Commit

Permalink
KEP-4210: retarget to beta for 1.30
Browse files Browse the repository at this point in the history
Signed-off-by: Peter Hunt <pehunt@redhat.com>
  • Loading branch information
haircommander committed Feb 7, 2024
1 parent ee39cec commit 706d265
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-node/4210.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
kep-number: 4210
alpha:
approver: "@johnbelamaric"
beta:
approver: "@johnbelamaric"
14 changes: 8 additions & 6 deletions keps/sig-node/4210-max-image-gc-age/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,14 @@ Additional tests will be added to this file to cover the garbage collection e2e.

- Configuration field added to the Kubelet (disabled by default)
- Feature supported by Kubelet Image Manager
- Unit tests and e2e tests added
- Unit tests
- Add a metric `kubelet_image_garbage_collected_total` which tracks the number of images the kubelet is GC'ing through any mechanism.

#### Beta

- Gather feedback from users
- Add e2e tests
- Document `kubelet_image_garbage_collected_total` (a step missed in alpha)
- Add "reason" field to `kubelet_image_garbage_collected_total` to allow distinguishing between GC reasons (space based or time based).

#### GA

Expand Down Expand Up @@ -276,8 +278,8 @@ removed, so no running workloads can be affected.

###### What specific metrics should inform a rollback?

- `kubelet_image_garbage_collected_total` metric drastically (100x) increasing, indicating thrashing of the GC manager and
images being pulled.
- `kubelet_image_garbage_collected_total` metric drastically (100x) increasing, with the "reason" field being "age",
indicating thrashing of the GC manager and images being pulled.

###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?

Expand All @@ -292,7 +294,7 @@ No.
###### How can an operator determine if the feature is in use by workloads?

- Verify the Kubelet Configuration with the Kubelet's configz endpoint
- Monitor the `kubelet_image_garbage_collected_total`, and expect a slight increase.
- Monitor the `kubelet_image_garbage_collected_total`, and expect some images are removed for reason "age"

###### How can someone using this feature know that it is working for their instance?

Expand All @@ -302,7 +304,6 @@ No.
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?

- The eventual default value should increase the average `kubelet_image_garbage_collected_total` by no more than 10x
- TODO: On what clusters?

###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?

Expand Down Expand Up @@ -370,6 +371,7 @@ No


2023-09-18: KEP opened, targeted at Alpha
2024-01-22: KEP updated to Beta

## Drawbacks

Expand Down
5 changes: 3 additions & 2 deletions keps/sig-node/4210-max-image-gc-age/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,17 @@ approvers:


# The target maturity stage in the current dev cycle for this KEP.
stage: alpha
stage: beta

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.29"
latest-milestone: "v1.30"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.29"
beta: "v1.30"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down

0 comments on commit 706d265

Please sign in to comment.