Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Catalog]: Pod Preset #162

Closed
8 of 23 tasks
jessfraz opened this issue Jan 6, 2017 · 18 comments
Closed
8 of 23 tasks

[Service Catalog]: Pod Preset #162

jessfraz opened this issue Jan 6, 2017 · 18 comments
Assignees
Labels
sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@jessfraz
Copy link

jessfraz commented Jan 6, 2017

Description

Add a policy resource that allows loose coupling from services to the pods that consume them.
Proposal here: kubernetes/community#254

Progress Tracker

  • Alpha
    • Write and maintain draft quality doc
      • During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK
    • Design Approval
    • Write (code + tests + docs) then get them merged. ALL-PR-NUMBERS
      • Code needs to be disabled by default. Verified by code OWNERS
      • Minimal testing
      • Minimal docs: Add pod preset docs website#2807
        • cc @kubernetes/docs on docs PR
        • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
        • New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io
      • Update release notes
  • Beta
    • Testing is sufficient for beta
    • User docs with tutorials
      - Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
      - cc @kubernetes/docs on docs PR
      - cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Thorough API review
      • cc @kubernetes/api
  • Stable
    • docs/proposals/foo.md moved to docs/design/foo.md
      - cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Soak, load testing
    • detailed user docs and examples
      • cc @kubernetes/docs
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@idvoretskyi
Copy link
Member

@jessfraz can you update this feature request with more details?
Which release does it target, which SIG is responsible for the feature, who is the feature owner?

@jessfraz
Copy link
Author

Yes sorry, is there a template for what details go here and what goes into the proposal?

@idvoretskyi
Copy link
Member

@jessfraz feel free to update the issue body (the new template is on the way)

@pwittrock pwittrock modified the milestones: v1.6, next-milestone Jan 20, 2017
@pwittrock pwittrock added the sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. label Jan 20, 2017
@pmorie pmorie changed the title [Service Catalog]: Service Injection Policy [Service Catalog]: Pod Injection Policy Feb 14, 2017
@idvoretskyi
Copy link
Member

@jessfraz will it be alpha (or beta/stable) for 1.6?

@jessfraz
Copy link
Author

jessfraz commented Feb 27, 2017 via email

@pwittrock
Copy link
Member

@jessfraz This is likely not landing in 1.6, correct?

@pwittrock pwittrock modified the milestones: next-milestone, v1.6 Feb 27, 2017
@pmorie
Copy link
Member

pmorie commented Feb 27, 2017

@pwittrock we're hoping to get it into 1.6, yes.

@pwittrock pwittrock modified the milestones: v1.6, next-milestone Feb 27, 2017
@duglin
Copy link

duglin commented Feb 28, 2017

should probably update the text here with the new name

@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 28, 2017
@pwittrock
Copy link
Member

Development complete and merged. Documentation in progress.

@bgrant0607 bgrant0607 changed the title [Service Catalog]: Pod Injection Policy [Service Catalog]: Pod Preset Mar 23, 2017
@devin-donnelly
Copy link

The docs PR for this still needs a tech review.

kubernetes/website#2807

@kuroneko25
Copy link

Any idea if this is going to hit beta in 1.7?

@idvoretskyi
Copy link
Member

@kuroneko25 features and code freeze deadlines are already passed, this feature is not targeting 1.7.

@duglin
Copy link

duglin commented Jul 25, 2017

In the sig-arch call yesterday they talked about moving PodPreset to the svc-cat repo and continuing the work over there. Not sure if this will make it for v1.8 or not since it will also require it to use initializers - and see this comment: kubernetes-retired/service-catalog#1041 (comment)

@idvoretskyi
Copy link
Member

@duglin @kubernetes/sig-service-catalog-feature-requests is it expected that this feature will be developed in a general Kubernetes scope (following the general timelines etc)?

If not, feel free to close the feature request.

@pwittrock
Copy link
Member

PodPreset is going to be moved to the service catalog incubator project.

@Stono
Copy link

Stono commented Nov 29, 2017

@pwittrock Sorry for commenting on a closed thread but I'm struggling to find any information when podpreset will be in beta (thus GA on GKE), every thread stream I seem to follow is closed.

Any ideas?

@alexkreidler
Copy link

Any updates on this? Are most Kubernetes APIs intended to stay in Alpha for almost 3 years?

I'm not really sure if this feature has the momentum behind it to go into beta, but I know lots of cloud kubernetes environments (EKS, GKE, etc) won't enable it unless it does, and I'm really looking forward to using this feature in a bigger way.

Let me know if anyone is still involved in this feature or if there's anything I can do to help!

@kfox1111
Copy link

I just bumped into this feature and it looks to be very useful to me. Whats the plan around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests

10 participants