Built-in API Types Defaults

[apelisse]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allow new declarative default marker for built-in API types

• Kubernetes Enhancement Proposal:https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1929-built-in-default

• Primary contact (assignee): @apelisse

• Responsible SIGs: sig-api-machinery

• Enhancement target (which target equals to which milestone):

  • Stable release target (x.y) 1.20

• Docs PR: Placeholder for Built-in Defaulting website#24640

[apelisse]

/sig api-machinery
/wg api-expression

[kikisdeliveryservice]

Hi @apelisse

Enhancements Lead here. Could you clarify your plans for 1.20? Above it says beta but in the kep.yaml in #1928 it says that 1.20 is stable.

Thanks!
Kirsten

[apelisse]

Thanks, I will, we're planning beta in 1.20

[apelisse]

Updated!

[kikisdeliveryservice]

/milestone v1.20

[kinarashah]

Hi @apelisse,

Enhancement shadow for 1.20 release here 👋.

I see that your KEP PR is under review, just wanted to remind you that the Enhancement freeze deadline for KEPs to be included in 1.20 milestone is Tuesday, October 6.

We're looking for the KEP PR to have the following before this deadline:

• should have test plans
• should have graduation criteria
• should have state implementable and merged

Please let me know if you have any questions, thank you!

[kinarashah]

Thank you @apelisse for actively working on the KEP PR!

Here's the status update based on the freeze requirements:

Requirement	Status	Comments
Test Plan	❓	does this comment need to be addressed?
Graduation Criteria	✅	Updated to - As an internal feature, this will go straight to stable.
Implementable State	✅	-
Merged	🏁	ℹ️ Approved by lavalamp, yet to be merged

Just a friendly reminder that we'd need all of them with ✅ status to be included in 1.20 milestone by Enhancement Freeze deadline Tuesday, October 6.

Thank you!!

[apelisse]

Thanks, I think I've addressed the test plan comment, and I'm now waiting for this PR to be merged!

[kinarashah]

Thank you @apelisse for the update, that sounds great! 🚢

[kinarashah]

Hi @apelisse,

Since this Enhancement is scheduled to be in 1.20, please keep in mind these important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

[reylejano]

Hello @apelisse , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[apelisse]

Created :-) Thanks!

[reylejano]

Hi @apelisse

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline DONE!
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[kikisdeliveryservice]

Hi @apelisse

I don't see any k/k prs attached to this issue? Can you update with the status?

Just a reminder that Code Freeze is coming up tomorrow on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks
Kirsten

[apelisse]

We're still working on it, thanks :-)

[kikisdeliveryservice]

Thanks! please link the prs to this issue once they are up.

[kikisdeliveryservice]

As per: kubernetes/website#24640 (comment)

One PR has merged(kubernetes/kubernetes#95423) but we are waiting for some others, and author will link them to issue once they are up.

[apelisse]

There's one, but it's failing because test-infra seems to be failing: kubernetes/kubernetes#96480
And then there's this: kubernetes/gengo#192
which is partly integrated here: kubernetes/kubernetes#96317

[kikisdeliveryservice]

Just to confirm, for k/k prs this requires:

• CRs: Default non-nullable nulls kubernetes#95423 (merged)
• Add defaults openapi kubernetes#96480 (fully approved, blocked by ci)
• Integrate defaults marker to defaulter-gen kubernetes#96317 (fully approved, failing some tests w/hold)

[apelisse]

The last PR is just the integration of kubernetes/gengo#192, it should move super fast.

[kikisdeliveryservice]

Hi @apelisse

Code Freeze is now in effect. You have 2 PRs that are still unmerged (one with a hold, both missing LGTMs). If you believe this should be in the 1.20 Release, please file an Exception.

Best,
Kirsten

[Jefftree]

Exception Request: https://groups.google.com/g/kubernetes-sig-api-machinery/c/4-mIVAD8GEI

[kikisdeliveryservice]

Exception granted: https://groups.google.com/g/kubernetes-sig-release/c/eCk4Xyb58GQ/m/tjgEstjyAQAJ

[kikisdeliveryservice]

kubernetes/kubernetes#96480 & kubernetes/kubernetes#96317 both need a rebase now 😦

[kikisdeliveryservice]

Looks like both prs have now merged!! 🎆

[verdverm]

Curious, why weren't Go struct tags used for this?

[apelisse]

In general, I think we're moving away from these. I can see why the are useful (they can be parsed at runtime), but they are also very hard to read, especially when we start to have many of these.

[lavalamp]

@apelisse do you want this for 1.21?

[apelisse]

No, this is already stable :-)

/close

[k8s-ci-robot]

@apelisse: Closing this issue.

In response to this:

No, this is already stable :-)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.