-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support services that reference an external service #33
Comments
@rata do you think you'll be able to code this in time for 1.4? |
On Mon, Jul 25, 2016 at 07:58:11AM -0700, Andy Goldstein wrote:
My plan was to start working on this on Tuesday, as I have an exam on Tuesday at I think the change can be not so hard, for the quick look I had at th code (it But if you are concerned about this, please go ahead and work on this! I can |
@rata that should be fine. I was just checking in. Thanks! |
@smarterclayton @rata which SIG is responsible for this feature? |
I would assume network |
@ncdc thanks |
@ncdc @smarterclayton @thockin I'm more busy than I expected (at $DAYJOB and university) and I'm not sure I'll make it on time on this. Do you want to start working on this, and if I have some time maybe jump on this later? |
I'm really really sorry, and I wish I could work on this, but I'm already late (planned to start 2 days ago) and more busy than I expected. I think it's better to say this early so this gets implemented in 1.4. But I'm really really sorry :-/ |
@smarterclayton Do you think you can find someone else to tackle? Or should we just punt to 1.5. |
I'm also working on node-local services, so perhaps I can help with this. That way, I can blame myself for the ensuing rebases. :-) |
@therc thanks again! :) |
@therc thank you for your help, assigned you as an assignee. |
ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33
ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33
ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33
In a meeting today, it was mentioned that this is missing v1.4. I'm moving to the v1.5 milestone. Please bring back to v1.4 if that's not accurate. |
ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33
ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33
ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33
ExternalName allows kubedns to return CNAME records for external services. No proxying is involved. See original issue at kubernetes#13748 Feature tracking at kubernetes/enhancements#33
On Thu, Oct 13, 2016 at 9:04 AM, Rudi C notifications@github.com wrote:
|
Thanks for working on this feature, it's been very helpful. |
@therc I don't think the CLI for this went in, did it? Any reason to not call what we have GA, anyway? Are you active on the CLI part or should we just open a new issue for it? |
This is stable in 1.5? Are there docs? |
The CLI did not, but the API change is in 1.4.
http://kubernetes.io/docs/user-guide/services/ - search for "ExternalName"
…On Mon, Dec 12, 2016 at 6:28 PM, Jimmy Cuadra ***@***.***> wrote:
This is stable in 1.5? Are there docs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVKpwQ33RKcvMjd5az7o6_WdQP_VUks5rHgLcgaJpZM4JQHJ2>
.
|
@smarterclayton @therc can you confirm the feature development has been completed and issue can be closed? |
@therc Can we count on you for CLI wrapup? would love to close this... |
@therc ping?
…On Thu, Jan 5, 2017 at 9:24 AM, Ihor Dvoretskyi ***@***.***> wrote:
@thockin <https://github.com/thockin> @therc <https://github.com/therc>
sooo, any final decision?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVB2ih9pim5d_LqxYdYzkyz-NZe7fks5rPSdKgaJpZM4JQHJ2>
.
|
Just got back from vacation and a hectic office move, working my way through email backlog. |
Oh, great, I missed that :) Can you cross-check the un-ticked boxes on
here, and if everything is done, we can close this out?
…On Tue, Jan 24, 2017 at 9:27 AM, Rudi C ***@***.***> wrote:
Just got back from vacation and a hectic office move, working my way
through email backlog.
I can pick up any leftover items, but I think kubectl create support was
implemented by @adohe <https://github.com/AdoHe> in
kubernetes/kubernetes#34789
<kubernetes/kubernetes#34789>
Was there anything else you had in mind? My next related step was allowing
the built-in kubernetes.default service to also be an ExternalName
service, to pave the way for a migration to api.kube-system or something
along those lines. But if you have something else that's higher priority, I
can tackle that first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVF0ojvj2dhIgnMo1TSq-xF7Qmqvzks5rVjSBgaJpZM4JQHJ2>
.
|
Unfortunately, I think only Clayton or another owner can edit the issue description. I just went through the checklist and it looks to me like everything can be ticked off. Regarding "detailed docs and examples", I have something with more use cases, originally for internal use, that I have almost entirely re-purposed as a blog post. I'm not sure how kosher it is to add links from Kubernetes docs to random external blog posts; I suspect not very, given link rot and the like. Perhaps I could re-adapt it again as a tutorial in the docs repo? This issue can be closed anyway. |
DONE |
The main feature is in 1.5 already and can be used through YAML files. It's the kubectl support that will land in 1.6. I think it'd be worthy of a 1.5 cherrypick. |
@idvoretskyi @therc yes, the kubectl support land in 1.6, shall we cherrypick it against 1.5? |
We don't typically backport new features |
Get it~ |
add open questions to the template
* Make TOC approval required for features in root Until we have better owners for the root of this, require TOC approval for changes. Also allow any maintainers to approve changes to /features. * Update CODEOWNERS
Description
Services should be able to reference an external DNS address instead of only pods, which will allow application authors to reference services that exist off platform, on other clusters, or locally.
Owner @rata
Progress Tracker
/pkg/apis/...
)FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT
More advice:
Design
Coding
and sometimes http://github.com/kubernetes/contrib, or other repos.
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing. They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.
Docs
The text was updated successfully, but these errors were encountered: