Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTL after finish #592

Closed
janetkuo opened this issue Jul 23, 2018 · 79 comments
Closed

TTL after finish #592

janetkuo opened this issue Jul 23, 2018 · 79 comments
Assignees
@janetkuo @ahg-g
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@janetkuo
Copy link
Member

janetkuo commented Jul 23, 2018 •
edited by soltysh
Loading

Feature Description
@janetkuo janetkuo added sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. labels Jul 23, 2018
@janetkuo janetkuo added this to the v1.12 milestone Jul 23, 2018
@janetkuo janetkuo self-assigned this Jul 23, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 25, 2018
@janetkuo janetkuo mentioned this issue Jul 31, 2018
Merged
@tnozicka
Copy link

tnozicka commented Aug 1, 2018

Design proposal link (community repo): https://goo.gl/YxtxTi

Does the google doc need to be moved to community repo?

@tnozicka
Copy link

Reviewers from multiple companies preferred

Happy to review as well and help fill in the diversity requirement here.

@janetkuo
Copy link
Member Author

Thanks @tnozicka! Added you as reviewer

@janetkuo
Copy link
Member Author

Updated link to KEP as well

@zparnold
Copy link
Member

Hey there! @janetkuo I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@janetkuo
Copy link
Member Author

@zparnold I've opened the docs PR: kubernetes/website#10064; it's still WIP

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Sep 5, 2018
Merge pull request #66840 from janetkuo/job-ttl
c50a347 
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```
k8s-publishing-bot added a commit to kubernetes/api that referenced this issue Sep 5, 2018
@k8s-publishing-bot
Merge pull request #66840 from janetkuo/job-ttl
012f271 
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```

Kubernetes-commit: c50a3471242fa33a111d493711c3477e691ccdea
sttts pushed a commit to sttts/api that referenced this issue Sep 5, 2018
@k8s-publishing-bot
Merge pull request #66840 from janetkuo/job-ttl
cdf34ea 
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```

Kubernetes-commit: c50a3471242fa33a111d493711c3477e691ccdea
@justaugustus
Copy link
Member

@janetkuo --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@janetkuo
Copy link
Member Author

janetkuo commented Sep 6, 2018 •
edited
Loading

@justaugustus yes we're landing it for 1.12. The docs is under review kubernetes/website#10064

@justaugustus
Copy link
Member

Thanks for the update, @janetkuo!

k8s-publishing-bot added a commit to kubernetes/kube-controller-manager that referenced this issue Sep 9, 2018
@k8s-publishing-bot
Merge pull request #66840 from janetkuo/job-ttl
4a2a2a4 
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```

Kubernetes-commit: c50a3471242fa33a111d493711c3477e691ccdea
@ameukam
Copy link
Member

ameukam commented Oct 5, 2018

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

@kacole2
Copy link

kacole2 commented Oct 8, 2018

@janetkuo following up from @ameukam's comment. Is there a plan for this to graduate to beta in 1.13?

@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 8, 2018
@janetkuo
Copy link
Member Author

janetkuo commented Oct 9, 2018

There's currently no plan to graduate it to beta in 1.13.

@kacole2
Copy link

kacole2 commented Oct 9, 2018

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Oct 9, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

This was referenced May 25, 2021
Merged
Closed
@sahilvv sahilvv mentioned this issue Jul 27, 2021
Merged
@salaxander
Copy link
Contributor

/milestone v1.23

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.23 Sep 1, 2021
@salaxander salaxander added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 1, 2021
@salaxander
Copy link
Contributor

salaxander commented Sep 1, 2021 •
edited
Loading

Hi @ahg-g! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like we're all set for enhancements freeze :)

Thanks!

@mmiranda96 mmiranda96 mentioned this issue Sep 16, 2021
Closed
@jlbutler
Copy link

Hi @ahg-g 👋 1.23 Docs lead here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@sahilvv sahilvv mentioned this issue Sep 23, 2021
Merged
@chrisnegus
Copy link

Hi @sahilvv 👋 1.23 Docs shadow here.

Just want to verify that there are two docs PRs to track for this KEP in 1.23:

kubernetes/website#29987
kubernetes/website#30031

@sahilvv
Copy link
Contributor

sahilvv commented Oct 12, 2021

@chrisnegus you can ignore kubernetes/website#29987. kubernetes/website#30031 contains all the changes needed for graduating this feature to stable in 1.23. Let me know if any further questions.

@salaxander
Copy link
Contributor

Hi @ahg-g. Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

@sahilvv
Copy link
Contributor

sahilvv commented Nov 4, 2021

@salaxander I am the owner of this KEP and feature to take to GA state in 1.23. To answer your questions:

  1. All PRs are merged to the k8s repo at this time
  2. Doc update PRs are merged to dev-1.23 branch at this time.

No pending tasks left related to this KEP to the best of my knowledge.

Thanks.

@salaxander
Copy link
Contributor

Hi @sahilvv - thanks for the update!

I've updated our tracking to show this as complete. When you get a chance, could you link the k/k PRs in the issue description?

Thanks!

@sahilvv
Copy link
Contributor

sahilvv commented Nov 8, 2021

@salaxander Following are the PRs to move this feature from Beta to Stable/GA state:

kubernetes/kubernetes#105219
kubernetes/website#30031

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 9, 2022
@gracenng gracenng removed this from the v1.23 milestone Jan 9, 2022
@gracenng
Copy link
Member

gracenng commented Jan 9, 2022

1.24 Enhancements Lead here,

@sahilvv, could you please update the KEP status to implemented and close this issue then?

Thanks :)

@sahilvv
Copy link
Contributor

sahilvv commented Jan 12, 2022

@gracenng pardon my dumb question, I did mark the KEP as stable in PR https://github.com/kubernetes/enhancements/pull/2841/files. Let me know where I need to flip the status to implemented.

@gracenng
Copy link
Member

hi @sahilvv , I could have been more clear. This line should be implemented instead of implementable

https://github.com/sahilvv/enhancements/blob/ee3a716a89c3aa0a16891447a46123bf9bd564f4/keps/sig-apps/592-ttl-after-finish/kep.yaml#L10

@sahilvv sahilvv mentioned this issue Jan 15, 2022
Merged
@sahilvv
Copy link
Contributor

sahilvv commented Jan 22, 2022

@gracenng above PR#3147 is merged. I am not sure how to close the issue as I don't see that as an option.

@gracenng
Copy link
Member

Done, thanks

@github-actions github-actions bot mentioned this issue May 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janetkuo janetkuo

@ahg-g ahg-g

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests