Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenStack Cloud Provider KEP #1303

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Oct 13, 2019

Openstack Cloud Provider has been implemented from long, This PR updated the KEP with current status of provider work. Fixes:#669

@k8s-ci-robot
Copy link
Contributor

Welcome @adisky!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Oct 13, 2019
@adisky
Copy link
Contributor Author

adisky commented Oct 13, 2019

/assign @lingxiankong @chrigl @ramineni @kendallnelson
please review this and help me in filling remaining TBD
cc @kayrus @zetaab @dims @hogepodge

@k8s-ci-robot
Copy link
Contributor

@adisky: GitHub didn't allow me to assign the following users: kendallnelson.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @lingxiankong @chrigl @ramineni @kendallnelson
please review this and help me in filling remaining TBD
cc @kayrus @zetaab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member

dims commented Oct 14, 2019

@adisky excellent, can we remove the in-tree in kubernetes 1.17?

@adisky
Copy link
Contributor Author

adisky commented Oct 14, 2019

@dims trying hard for removal in v1.17

@hogepodge
Copy link

Oh please, yes. CSI migration is the only thing blocking this? @adisky if the code isn't removed (or the storage code stays) we also have to switch to using the utils/mount package rather than the duplicated code we used for the staging patch.

@kendallnelson

@ramineni
Copy link
Contributor

@hogepodge Still mount package PR is not yet merged in utils package (not updated from long time), keeping an eye on that as well , if removal not completed in time , Ill submit a PR to use new mount package if merged

Copy link

@kendallnelson kendallnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but my opinion definitely shouldn't have the weight that other's do.

@adisky adisky changed the title [WIP] Update OpenStack Cloud Provider KEP Update OpenStack Cloud Provider KEP Nov 4, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2019
@adisky
Copy link
Contributor Author

adisky commented Nov 4, 2019

removed WIP, some fields are still TODO, we will update them as per our progress.
/assign @andrewsykim

@andrewsykim
Copy link
Member

/approve
/lgtm

Thanks @adisky

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, andrewsykim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit e62401d into kubernetes:master Nov 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants