-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: add KEP for moving kubeadm out of k/k #1425
Conversation
@kubernetes/sig-cluster-lifecycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @neolit123, this is a stunning proposal, so well described and detailed.
I'm missing testing and release sorcery so some comments on a first pass.
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neolit123 !
Looks possible. Although I am not sure if it all can be squeezed in a single release cycle.
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
This is super dope, @neolit123! Thank you for the major contribution! |
if this spans across multiple releases it is going to be tricky. potentially the release tooling changes can be developed in one cycle and put on hold (unused) until the rest is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @neolit123 for writing all this, I reviewed the document and left some feedbacks.
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neolit123 thanks for this work!
Overall it looks great, only few minors here and there, but nothing blocking/that cannot be addressed later on.
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/kubeadm/20191229-kubeadm-move-out-of-kk.md
Outdated
Show resolved
Hide resolved
with respect to the proposals to automate certain aspects of the process. this is something we can grade over time. the goal right now is to get the KEP in an "implementable" state before the deadline, and:
|
@neolit123 point taken |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/lifecycle frozen |
Enhancement issues opened in /remove-lifecycle frozen |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/lifecycle frozen |
@fabriziopandini: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
@dims another fun quirk #1425 (comment) kubernetes/kubernetes#103151 perhaps this PR should be re-filed when people are ready to more forward with it? I recall dims was interested and I see this got many review comments but .. O(years) ago. |
I think it's fine to close this PR and revisit once the discussions between
sig release and cli start for the external kubectl release process. I will
leave the branch.
/close
|
@neolit123: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @timothysc @fabriziopandini @rosti @ereslibre @detiber @yastij
cc @LucaLanziani