Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: add KEP for moving kubeadm out of k/k #1425

Closed
wants to merge 1 commit into from

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Dec 29, 2019
@neolit123 neolit123 added this to the v1.18 milestone Dec 29, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 29, 2019
@neolit123
Copy link
Member Author

@kubernetes/sig-cluster-lifecycle
@kubernetes/sig-docs-en-owners @kubernetes/release-engineering

Copy link

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @neolit123, this is a stunning proposal, so well described and detailed.

I'm missing testing and release sorcery so some comments on a first pass.

@justaugustus
Copy link
Member

/cc @justaugustus @tpepper

@neolit123 neolit123 changed the title [WIP] kubeadm: add KEP for moving kubeadm out of k/k kubeadm: add KEP for moving kubeadm out of k/k Jan 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2020
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neolit123 !
Looks possible. Although I am not sure if it all can be squeezed in a single release cycle.

@onlydole
Copy link
Member

onlydole commented Jan 9, 2020

This is super dope, @neolit123! Thank you for the major contribution!

@neolit123
Copy link
Member Author

@rosti

Looks possible. Although I am not sure if it all can be squeezed in a single release cycle.

if this spans across multiple releases it is going to be tricky. potentially the release tooling changes can be developed in one cycle and put on hold (unused) until the rest is ready.

Copy link

@LucaLanziani LucaLanziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @neolit123 for writing all this, I reviewed the document and left some feedbacks.

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 thanks for this work!
Overall it looks great, only few minors here and there, but nothing blocking/that cannot be addressed later on.

@neolit123
Copy link
Member Author

with respect to the proposals to automate certain aspects of the process. this is something we can grade over time. the goal right now is to get the KEP in an "implementable" state before the deadline, and:

  • making sure a "minimal viable product" for the repository move is feasible.
  • the process of maintaining kubeadm from a different repository, without being polished, will not end up causing major troubles for us.

@fabriziopandini
Copy link
Member

@neolit123 point taken
From my PoV, release/release tag automation will really help, everything else can be improved in subsequent iterations.
For the sake of this KEP, it will be ok to add a note where there is room for such improvements

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2020
@neolit123 neolit123 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2020
@neolit123 neolit123 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2020
@fabriziopandini
Copy link
Member

/lifecycle frozen
We should put some effort again on this work and try to overcome current external blockers

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 17, 2020
@fejta-bot
Copy link

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 17, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@neolit123 neolit123 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@fabriziopandini
Copy link
Member

/remove-lifecycle stale

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 15, 2021
@fabriziopandini
Copy link
Member

/lifecycle frozen

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 23, 2021
@BenTheElder
Copy link
Member

@dims another fun quirk #1425 (comment) kubernetes/kubernetes#103151

perhaps this PR should be re-filed when people are ready to more forward with it? I recall dims was interested and I see this got many review comments but .. O(years) ago.

@neolit123
Copy link
Member Author

neolit123 commented Jul 23, 2021 via email

@k8s-ci-robot
Copy link
Contributor

@neolit123: Closed this PR.

In response to this:

I think it's fine to close this PR and revisit once the discussions between
sig release and cli start for the external kubectl release process. I will
leave the branch.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.