Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 20190125-out-of-tree-openstack.md #1492

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Update 20190125-out-of-tree-openstack.md #1492

merged 2 commits into from
Feb 3, 2020

Conversation

ramineni
Copy link
Contributor

@ramineni ramineni commented Jan 22, 2020 •
edited
Loading

This PR marks the KEP as implementable.
related to : #669

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jan 22, 2020
@ramineni
Copy link
Contributor Author

cc @adisky

@johnbelamaric
Copy link
Member

Is this complete or not? If it's complete, it should be implemented. If it's still in progress, then implementable makes sense.

@ramineni
Copy link
Contributor Author

Is this complete or not? If it's complete, it should be implemented. If it's still in progress, then implementable makes sense.

Thanks. Marked as implemented.

@adisky
Copy link
Contributor

adisky commented Jan 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2020
andrewsykim
andrewsykim reviewed Jan 24, 2020
View reviewed changes
keps/sig-cloud-provider/20190125-out-of-tree-openstack.md
@@ -83,7 +83,7 @@ OpenStack Cloud Provider is well tested, CI running at [OpenLab](https://github.

### Graduation Criteria

This feature is complete, well tested, in parity with intree openstack provider. Documents needs to be updated as per sig-cloud-provider guideline.
This feature is complete, well tested, in parity with intree openstack provider. Documention regarding migration from in-tree cloud provider to openstack-cloud-controller-manager can be found [here](https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/migrate-to-ccm-with-csimigration.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there also general docs on installing the out-of-tree openstack provider?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim yes, we have documentation regarding installing ccm using kubeadm and also getting started guide on installing the provider on configuration needed for using external provider. https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-controller-manager-with-kubeadm.md , https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/getting-started-provider-dev.md

@andrewsykim
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, andrewsykim, ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit ab5927a into kubernetes:master Feb 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@adisky adisky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@ramineni @johnbelamaric @adisky @andrewsykim @k8s-ci-robot