Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEP-1933] Correct stable version to 1.23, not 1.22 #2942

Merged

Conversation

PurelyApplied
Copy link
Contributor

@PurelyApplied PurelyApplied commented Sep 3, 2021

  • One-line PR description: Correct stable version to 1.23, not 1.22.
  • Other comments: This change comes at the recommendation of @gracenng as 1.23 enhancement shadow. Since we recently merged the "official" stable state in the KEP's YAML, it should be reflected in 1.23 for enhancement tracking, not back-dating 1.22 of when scanning became blocking.
  • Also, I noticed I left a trailing, empty comment line. Trimmed that form the YAML.

/sig security
/cc gracenng

@k8s-ci-robot k8s-ci-robot added sig/security Categorizes an issue or PR as relevant to SIG Security. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Sep 3, 2021
@PurelyApplied
Copy link
Contributor Author

Hmm, misunderstood how the bot autopopulates fields... Pulling cc and assign from recent #2847.

/cc tabbysable IanColdwater
/assign ehashman

Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I was gonna ask about that :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2021
@deads2k
Copy link
Contributor

deads2k commented Sep 7, 2021

/approve

1 similar comment
@tabbysable
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, PurelyApplied, tabbysable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit fe1ab76 into kubernetes:master Oct 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants