Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3299-kms-v2-improvements #3302

Merged
merged 21 commits into from
Jun 17, 2022
Merged

3299-kms-v2-improvements #3302

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b0345e6
3299-kms-v2-improvements
ritazh May 9, 2022
9cbc4c7
chore: add sequence diagram for encrypt and decrypt request
aramase May 9, 2022
a7dde44
Merge pull request #1 from aramase/3299-kms-v2
ritazh May 9, 2022
fbbe62a
Address comments
ritazh May 10, 2022
2ea5c24
Update cipher to ciphertext, plain to plaintext
ritazh May 10, 2022
b4a4b95
chore: use snake case for non-generated proto API
aramase May 18, 2022
6d3d847
Merge pull request #2 from aramase/3299-kms-v2
ritazh May 18, 2022
31634ad
Scope rotation to a single api server
ritazh May 18, 2022
294bac0
chore: updates based on review feedback
aramase Jun 7, 2022
b9e2436
Merge pull request #3 from aramase/review-update-1
ritazh Jun 8, 2022
4f265c3
address review comments
ritazh Jun 9, 2022
1442adb
update casing
ritazh Jun 9, 2022
a3d6c7e
add annotations to encryptedObject
ritazh Jun 10, 2022
8fca627
add more test plan sections
ritazh Jun 10, 2022
3355fd1
Merge pull request #4 from ritazh/review-updates
ritazh Jun 10, 2022
6f80e8e
add comments for encrypted object (#5)
aramase Jun 14, 2022
ebedb57
add additional prr questions (#6)
aramase Jun 15, 2022
93dff58
add steps for disabling feature
aramase Jun 15, 2022
fecf9a7
Merge pull request #7 from aramase/rollback-comments
ritazh Jun 15, 2022
a0405db
add more details for livez and readyz
aramase Jun 16, 2022
43a2a55
Merge pull request #8 from aramase/add-readyz-healthz
ritazh Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions keps/prod-readiness/sig-auth/3299.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kep-number: 3299
alpha:
approver: "@deads2k"
2 changes: 1 addition & 1 deletion keps/sig-auth/3130-kms-observability/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors:
owning-sig: sig-auth
participating-sigs:
- sig-auth
status: implementable
status: replaced
creation-date: 2022-01-12
reviewers:
- "@enj"
Expand Down
Loading