Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2802: Promote PodOS field to GA #3303

Merged
merged 2 commits into from
Jun 10, 2022
Merged

KEP-2802: Promote PodOS field to GA #3303

merged 2 commits into from
Jun 10, 2022

Conversation

ravisantoshgudimetla
Copy link
Contributor

  • One-line PR description:

Promote PodOS field to GA

  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2022
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 9, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

cc @liggitt @marosset @jsturtevant @jayunit100

@kikisdeliveryservice kikisdeliveryservice changed the title Promote PodOS field to GA KEP 2802: Promote PodOS field to GA May 10, 2022
@kikisdeliveryservice kikisdeliveryservice changed the title KEP 2802: Promote PodOS field to GA KEP-2802: Promote PodOS field to GA May 10, 2022
@liggitt
Copy link
Member

liggitt commented May 11, 2022

one typo, lgtm otherwise

@marosset marosset mentioned this pull request May 11, 2022
Closed
26 tasks
@marosset
Copy link
Contributor

/approve

@marosset
Copy link
Contributor

@ravisantoshgudimetla - can you add the new test-plan section to this KEP?

@marosset
Copy link
Contributor

I see we have some information around test-plan but the enhancements team will be looking for the information in the KEP template.

@ravisantoshgudimetla
Copy link
Contributor Author

I see we have some information around test-plan but the enhancements team will be looking for the information in the KEP template.

Sure, let me look at the template.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2022
@marosset
Copy link
Contributor

marosset commented Jun 7, 2022

Thanks for adding the new test section.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@deads2k
Copy link
Contributor

deads2k commented Jun 10, 2022

PRR still lgtm

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, marosset, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit fda49d0 into kubernetes:master Jun 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@ravisantoshgudimetla @liggitt @marosset @deads2k @k8s-ci-robot