Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2579: Pod Security GA plan #3310

Merged
merged 5 commits into from
May 18, 2022
Merged

KEP-2579: Pod Security GA plan #3310

merged 5 commits into from
May 18, 2022

Conversation

tallclair
Copy link
Member

/sig auth

@tallclair tallclair added this to the v1.25 milestone May 11, 2022
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2022
@k8s-ci-robot k8s-ci-robot requested a review from enj May 11, 2022 18:22
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 11, 2022
@k8s-ci-robot k8s-ci-robot requested a review from liggitt May 11, 2022 18:22
@tallclair tallclair mentioned this pull request May 11, 2022
Closed
12 tasks
@kikisdeliveryservice
Copy link
Member

Hi @tallclair

We recently updated the Test Plan section of the KEP template. If possible, can you pick up those changes and fill out for GA where applicable?

Thanks!
Best,
Kirsten
Sig-Arch/Enhancements Sub-project

@liggitt
Copy link
Member

liggitt commented May 11, 2022

also needs PRR stage added (see CI failure)

@tallclair tallclair mentioned this pull request May 12, 2022
Merged
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2022
@tallclair
Copy link
Member Author

Comments addressed.

Regarding the new testing sections, I left a friction log with some feedback on the original PR: #3279 (comment)

@liggitt
Copy link
Member

liggitt commented May 13, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2022
@deads2k
Copy link
Contributor

deads2k commented May 18, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6a4aadc into kubernetes:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@enj enj Awaiting requested review from enj

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@tallclair @kikisdeliveryservice @liggitt @deads2k @k8s-ci-robot