Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kep for beta graduation in 1.25 #3319

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Update kep for beta graduation in 1.25 #3319

merged 1 commit into from
Jun 9, 2022

Conversation

kevindelgado
Copy link
Contributor

  • One-line PR description: Update PR for beta milestone targeting 1.25 (fix metadata field validation)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 26, 2022
@kevindelgado
Copy link
Contributor Author

/assign @liggitt

@kevindelgado kevindelgado force-pushed the 2885-ss-field-validation-beta-1-25 branch 2 times, most recently from adff69a to fe2ea29 Compare May 26, 2022 07:38
@kevindelgado kevindelgado force-pushed the 2885-ss-field-validation-beta-1-25 branch from fe2ea29 to 5f5d3b6 Compare May 26, 2022 07:41
@liggitt
Copy link
Member

liggitt commented May 26, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2022
@kevindelgado
Copy link
Contributor Author

/assign deads2k

@deads2k
Copy link
Contributor

deads2k commented Jun 9, 2022

retargetting looks good.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, kevindelgado, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 17f615e into kubernetes:master Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@kevindelgado @liggitt @deads2k @k8s-ci-robot