Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vsphere csi migration test plan #3366

Merged
merged 1 commit into from
Jun 14, 2022
+35 −4
Merged

Update vsphere csi migration test plan #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions keps/sig-storage/1491-csi-migration-vsphere/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
<!-- toc -->
- [Summary](#summary)
- [New Feature Gates](#new-feature-gates)
- [Design Details](#design-details)
- [Prerequisite testing updates](#prerequisite-testing-updates)
- [Unit tests](#unit-tests)
- [Integration tests](#integration-tests)
- [e2e tests](#e2e-tests)
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
- [Implementation History](#implementation-history)
<!-- /toc -->
Expand Down Expand Up @@ -35,6 +40,28 @@ used as as described in its parent KEP. For all other contents, please refer to
on kubelet and treat vSphere CSI migration as already complete. And directly redirect traffic to CSI
driver for all vsphere volume related operations.

## Design Details
[X] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.
### Prerequisite testing updates
No additional prerequisite tests are needed.


### Unit tests
Unit tests for vSphere CSI Migration is added in the csi-translation-lib repository
- https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/vsphere_volume_test.go (85.1% coverage)

### Integration tests
- No Integration tests required for this feature

### e2e tests
- Existing e2e tests developed for in-tree vSphere volume plugin executed - https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/vsphere
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CSI migration we also want to ensure that tests inside - https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/testsuites are passing before and after migration, using intree PVs. Can you please update this section? It is pretty much a requirement for all CSI migration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnufied addressed your review comment in this PR - #3398

- Additional tests added in the [vSphere CSI Driver repository](https://github.com/kubernetes-sigs/vsphere-csi-driver) to ensure vSphere CSI Migration is production ready.
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_create_delete.go
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_attach_detach.go
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_full_sync.go
- https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/vcp_to_csi_syncer.go

## Production Readiness Review Questionnaire

Expand All @@ -54,5 +81,8 @@ Major milestones for vSphere in-tree plugin CSI migration:
- 1.19
- vSphere CSI migration to Beta, off by default

- 1.24
- vSphere CSI migration to Beta, on by default
- 1.25
divyenpatel marked this conversation as resolved.
Show resolved Hide resolved
- vSphere CSI migration to Beta, On by default

- 1.26
- vSphere CSI migration to Stable
5 changes: 3 additions & 2 deletions keps/sig-storage/1491-csi-migration-vsphere/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ approvers:
- "@msau42"
editor: "@Jiawei0227"
creation-date: 2022-01-11
last-updated: 2022-01-11
last-updated: 2022-08-11
disable-supported: true
status: implementable
see-also:
Expand All @@ -27,12 +27,13 @@ stage: beta
# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.24"
latest-milestone: "v1.25"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.18"
beta: "v1.19"
stable: "v1.26"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down