Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2831: update KEP testing plan, implementation history, & milestones #3404

Merged
merged 1 commit into from
Jun 22, 2022
Merged

KEP-2831: update KEP testing plan, implementation history, & milestones #3404

merged 1 commit into from
Jun 22, 2022

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Jun 16, 2022

  • One-line PR description: Updated test plan, updated milestones to 1.25, and updated implementation history

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jun 16, 2022
@sallyom sallyom mentioned this pull request Jun 16, 2022
Open
12 tasks
@marosset
Copy link
Contributor

/cc

@sallyom sallyom force-pushed the tracing-kubelet-add-test-plan branch from 2924f98 to 66a1e29 Compare June 17, 2022 20:49
@mrunalp
Copy link
Contributor

mrunalp commented Jun 21, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2022
@mrunalp
Copy link
Contributor

mrunalp commented Jun 21, 2022

/assign @dchen1107

@dchen1107
Copy link
Member

/approve

@mrunalp
Copy link
Contributor

mrunalp commented Jun 21, 2022

/assign @dgrisonnet

@dchen1107 dchen1107 added this to the v1.25 milestone Jun 21, 2022
@dchen1107
Copy link
Member

/lgtm
/approve

@dgrisonnet
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, dgrisonnet, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit c3c2509 into kubernetes:master Jun 22, 2022
@haircommander haircommander mentioned this pull request Jun 27, 2022
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole Awaiting requested review from dashpole

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@marosset marosset Awaiting requested review from marosset

Assignees

@mrunalp mrunalp

@dchen1107 dchen1107

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
6 participants
@sallyom @marosset @mrunalp @dchen1107 @dgrisonnet @k8s-ci-robot