Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-127: Update feature gate name and update last-milestone for 1.29 #4147

Merged
merged 2 commits into from
Sep 25, 2023
Merged

KEP-127: Update feature gate name and update last-milestone for 1.29 #4147

merged 2 commits into from
Sep 25, 2023

Conversation

rata
Copy link
Member

@rata rata commented Aug 7, 2023 •
edited
Loading

We changed the feature flag name in 1.28, when we added support for stateful pods too.
We also want to do changes in 1.29(PSS integration with sig-auth), so update the last-milestone to that.

  • One-line PR description: Update feature gate name
  • Other comments:

cc @giuseppe @saschagrunert @mrunalp

@rata
KEP-127: Update feature gate name
8f76c30 
We changed the feature flag name in 1.28, when we added support for
stateful pods too.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Aug 7, 2023

/cc @giuseppe @saschagrunert

@pacoxu
Copy link
Member

pacoxu commented Aug 8, 2023

/lgtm
/assign @dchen1107 @derekwaynecarr @SergeyKanzhelev @mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
giuseppe
giuseppe approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rata
Copy link
Member Author

rata commented Aug 21, 2023

/ assign mrunalp

It seems it didn't work before?

@rata
Copy link
Member Author

rata commented Aug 21, 2023

/assign @mrunalp

@pacoxu pacoxu mentioned this pull request Sep 5, 2023
Open
26 tasks
@rata
KEP-127: We will make changes in 1.29
1c6cae1 
The PSS integration is expected to go in this cycle at least.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2023
@rata rata changed the title KEP-127: Update feature gate name KEP-127: Update feature gate name and update last-milestone for 1.29 Sep 21, 2023
@rata
Copy link
Member Author

rata commented Sep 21, 2023

@pacoxu PTAL. Updated the PR to include the latest-milestone (this PR is open for so long that now I'm just including that), as requested here: #127 (comment)

pacoxu
pacoxu approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2023
@rata
Copy link
Member Author

rata commented Sep 21, 2023

Anything else I can do to move this forward? It's been open for ~1.5 months and the KEP is marked as at risk now due to just this simple PR not being merged :(

@giuseppe
Copy link
Member

@mrunalp could you please take a look?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mrunalp, pacoxu, rata, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit dcde279 into kubernetes:master Sep 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@giuseppe giuseppe giuseppe approved these changes

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@mrunalp mrunalp

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
7 participants
@rata @bart0sh @pacoxu @giuseppe @k8s-ci-robot @mrunalp @saschagrunert