KEP-3299: update KMS v2 design to match v1.28 implementation #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
the
cncf-cla: no
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/auth
Signed-off-by: Monis Khan <mok@microsoft.com>
Signed-off-by: Monis Khan <mok@microsoft.com>
enj
force-pushed
the
enj/f/kms_v2_128
branch
from
051bbab
to
77b78d7
Compare
k8s-ci-robot
added
cncf-cla: yes
aramase
reviewed
Sep 19, 2023
| @@ -86,7 +89,8 @@ This KEP proposes the new v2 `KeyManagementService` service contract to: | |||
| - enable fully automated key rotation for the latest key | |||
| - improve KMS plugin health check reliability | |||
| - improve observability of envelop operations between kube-apiserver, KMS plugins and KMS | |||
| - if this v2 API reaches GA in release N, the existing v1beta1 gRPC API will be deprecated at release N and removed at release N+3 (the existing key rotation dance of using multiple providers will be used to migrate from v1beta1 to v2) | |||
| - if this v2 API reaches beta in release M, the existing v1beta1 gRPC API will be deprecated at release M | |||
There was a problem hiding this comment.
We deprecated KMSv1 in v1.28 and KMSv2 beta was in v1.27, so should this be deprecated at release M+1?
There was a problem hiding this comment.
See if you like 5b8d99b better.
Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kubernetes/kubernetes#118837
/assign aramase