Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMSv2: Update KEP for GA #4226

Merged
merged 1 commit into from
Sep 22, 2023
Merged

KMSv2: Update KEP for GA #4226

merged 1 commit into from
Sep 22, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 20, 2023

fixes kubernetes/kubernetes#120308

/sig auth
/triage accepted
/assign enj

@aramase
KMSv2: Update KEP for GA
2195255 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
@enj
Copy link
Member

enj commented Sep 20, 2023

/lgtm

/assign liggitt

For review of GA criteria / general KEP stuff.

/assign deads2k

For PRR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@liggitt
Copy link
Member

liggitt commented Sep 20, 2023

/approve

@deads2k
Copy link
Contributor

deads2k commented Sep 22, 2023

Glad to see this moving.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit ad40779 into kubernetes:master Sep 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 22, 2023
@aramase aramase deleted the aramase/f/kms_kep_ga_update branch September 22, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@liggitt liggitt

@enj enj

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

[KMSv2] update KEP with targeting GA in v1.29
5 participants
@aramase @enj @liggitt @deads2k @k8s-ci-robot