CDI for device plugins: update test grid and triage links #4521
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
sig/node
k8s-ci-robot
requested review from
elezar,
kannon92,
klueska and
SergeyKanzhelev
| @@ -157,10 +157,10 @@ This test case has been added to the existing `e2e_node` tests: | |||
| - DevicePlugin can make a CDI device accessible in a container | |||
|
|
|||
| Links to test grid: | |||
| - https://testgrid.k8s.io/sig-node-containerd#e2e-cos-device-plugin-gpu | |||
There was a problem hiding this comment.
This change was because we got rid of this job and we are replacing it with the crio job?
There was a problem hiding this comment.
This is because we now have a job that runs only CDI-related tests, so these links are more appropriate in this KEP in my opinion.
There was a problem hiding this comment.
My main point about bringing up crio was making sure we had both crio and containerd coverage for GA. Do we have containerd tests for this feature still?
There was a problem hiding this comment.
No, we don't. I was planning to enable CDI tests for containerd 2.0, where CDI is enabled by default. However, I can create a Containerd job similar to the CRI-O one if needed.
There was a problem hiding this comment.
So what kind of guards do you have in place that this wouldn't break in containerd without these tests? If its covered somewhere I guess its fine.
There was a problem hiding this comment.
It's partly covered by DRA e2e as it also depends on CDI.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
/remove-lifecycle stale |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bart0sh, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
One-line PR description: CDI for device plugins: update test grid and triage links
Issue link: Add CDI devices to device plugin API #4009
Other comments: New test infra job has been created to test CDI support for device plugins to make sure other tests will not influence graduation of this feature to GA. This PR updates test grid and triage links to point to the new job.