-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coscheduilng. #639
Coscheduilng. #639
Conversation
xref #583 |
/assign bsalamat |
/cc adding this one to my backlog |
I think this proposal is a good starting point for introducing gang scheduling. Given that our current plan is to build an early version in kube-batch (which is an incubator, not a core component), this looks good to me. We should expand the proposal in the future with more in-depth information about life-cycle and quota management of gangs. |
I would like a section on how this will interact with cluster autoscaling added to the doc. I don't expect it to work with CA in initial version, but we should make sure the design is not fundamentally conflicting with how CA works if we want to promote it to core kubernetes later on. |
Coscheduling is not a predicate in scheduler; if necessary, CA need to check
How CA handle scheduler extender ? |
When discussing CA + kube-batch at kubernetes-retired/kube-batch#526 (comment) , I'm thinking to add more info in PodGroupStatus for CA to scale out. |
I replied on kubernetes-retired/kube-batch#533 (review). Let's continue the discussion in a single thread. |
Thanks for your reply. I marked Cluster-Autoscaler as out-of-scope in this version; I'll open other PRs when we have alternative solution for it. |
I'm perfectly fine with that as long as the feature lives in kube-batch (which is incompatible with CA anyway). We need to figure out how to make it work with CA if/when we want to move the feature to default scheduler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you could format this following the template?
For example, what would the graduation criteria for this look like?
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
More improvements to this design is needed in the area of life-cycle management of pod groups, but those can be added later, given that this design is going to an incubator project for now and won't be integrated into standard components.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Da K. Ma klaus1982.cn@gmail.com
Moved kubernetes/community#2337 to k/enhancements.
/cc @bsalamat, @vishh, @mindprince, @jlewi
/cc @kubernetes/sig-scheduling-feature-requests