Support parsing type parameters

[TheSpiritXIII]

This PR allows the parser to parse generics (partial fix for #225).

However, this PR does not allow generators to take advantage of it. For example, the deepcopy generator will still fail if you use a generic field, because it does not know whether that generic has a DeepCopy method. Although, the deepcopy generator will now work when you use a phantom type, which was not possible before. What are the use-cases for a phantom type? No clue, but I figured splitting the fix for #225 into multiple PRs would be easier to get reviewed and merged.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: TheSpiritXIII / name: Daniel Hrabovcak (239d3d4)

[k8s-ci-robot]

Welcome @TheSpiritXIII!

It looks like this is your first PR to kubernetes/gengo 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/gengo has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @TheSpiritXIII. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[thockin]

If you are still keen to merge this - could you rebase it to gengo/v2? I'd like to see this fixed.

[TheSpiritXIII]

If you are still keen to merge this - could you rebase it to gengo/v2? I'd like to see this fixed.

Thanks! I've split this PR into two, as deepcopy has moved into kubernetes/kubernetes. The deepcopy test PR can be found here: kubernetes/kubernetes#123996 Note, I had to upgrade gengo in that repository. Also, since Go workspaces don't support local replace directives, I used my local copy for now and marked the PR as WIP until this PR is released.

[thockin]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheSpiritXIII, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment