Merge pull request #964 from skmatti/cherrypick-log-fix

Cherrypick #963[Emit events only for non-nil ingresses] into release 1.8
kubernetes · Dec 4, 2019 · 3e8d844 · 3e8d844
2 parents aa1add9 + a4737bc
commit 3e8d844
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/controller/controller.go b/pkg/controller/controller.go
@@ -527,7 +527,8 @@ func (lbc *LoadBalancerController) sync(key string) error {
 		frontendGCAlgorithm := frontendGCAlgorithm(ingExists, ing)
 		// GC will find GCE resources that were used for this ingress and delete them.
 		err := lbc.ingSyncer.GC(allIngresses, ing, frontendGCAlgorithm)
-		if err != nil {
+		// Skip emitting an event if ingress does not exist as we cannot retrieve ingress namespace.
+		if err != nil && ingExists {
 			lbc.ctx.Recorder(ing.Namespace).Eventf(ing, apiv1.EventTypeWarning, "GC", fmt.Sprintf("Error during GC: %v", err))
 		}
 		return err