Add new metric status PersistentError for L4 DualStack

Report PersistentError if service is in Error after 20 minutes of
retries

pkg/l4lb/l4controller_test.go

@@ -638,6 +638,32 @@ func TestProcessDualStackServiceOnUserError(t *testing.T) {
 	}
 }
 
+func TestDualStackILBStatusForErrorSync(t *testing.T) {
+	l4c := newServiceController(t, newFakeGCEWithUserNoIPv6SubnetError())
+	l4c.enableDualStack = true
+	(l4c.ctx.Cloud.Compute().(*cloud.MockGCE)).MockForwardingRules.InsertHook = mock.InsertForwardingRulesInternalErrHook
+
+	newSvc := test.NewL4ILBDualStackService(8080, api_v1.ProtocolTCP, []api_v1.IPFamily{api_v1.IPv4Protocol, api_v1.IPv6Protocol}, api_v1.ServiceExternalTrafficPolicyTypeCluster)
+	addILBService(l4c, newSvc)
+	addNEG(l4c, newSvc)
+	syncResult := l4c.processServiceCreateOrUpdate(newSvc)
+	if syncResult.Error == nil {
+		t.Fatalf("Failed to generate error when syncing service %s", newSvc.Name)
+	}
+	if syncResult.MetricsState.IsUserError {
+		t.Errorf("syncResult.MetricsState.IsUserError should be false, got true")
+	}
+	if syncResult.MetricsState.InSuccess {
+		t.Errorf("syncResult.MetricsState.InSuccess should be false, got true")
+	}
+	if syncResult.DualStackMetricsState.Status != metrics.StatusError {
+		t.Errorf("syncResult.DualStackMetricsState.Status should be %s, got %s", metrics.StatusError, syncResult.DualStackMetricsState.Status)
+	}
+	if syncResult.DualStackMetricsState.FirstSyncErrorTime == nil {
+		t.Fatalf("Metric status FirstSyncErrorTime for service %s/%s mismatch, expected: not nil, received: nil", newSvc.Namespace, newSvc.Name)
+	}
+}
+
 func TestProcessUpdateILBIPFamilies(t *testing.T) {
 	testCases := []struct {
 		desc              string

pkg/loadbalancers/l4.go

@@ -283,11 +283,12 @@ func (l4 *L4) getFRNameWithProtocol(protocol string) string {
 func (l4 *L4) EnsureInternalLoadBalancer(nodeNames []string, svc *corev1.Service) *L4ILBSyncResult {
 	l4.Service = svc
 
+	startTime := time.Now()
 	result := &L4ILBSyncResult{
 		Annotations:           make(map[string]string),
-		StartTime:             time.Now(),
+		StartTime:             startTime,
 		SyncType:              SyncTypeCreate,
-		DualStackMetricsState: metrics.InitServiceDualStackMetricsState(svc),
+		DualStackMetricsState: metrics.InitServiceDualStackMetricsState(svc, &startTime),
 	}
 
 	// If service already has an IP assigned, treat it as an update instead of a new Loadbalancer.
@@ -388,6 +389,7 @@ func (l4 *L4) EnsureInternalLoadBalancer(nodeNames []string, svc *corev1.Service
 	}
 	if l4.enableDualStack {
 		result.DualStackMetricsState.Status = metrics.StatusSuccess
+		result.DualStackMetricsState.FirstSyncErrorTime = nil
 	}
 	return result
 }

pkg/loadbalancers/l4netlb.go

@@ -74,7 +74,7 @@ func NewL4SyncResult(syncType string, svc *corev1.Service) *L4NetLBSyncResult {
 		StartTime:             startTime,
 		SyncType:              syncType,
 		MetricsState:          metrics.InitL4NetLBServiceState(&startTime),
-		DualStackMetricsState: metrics.InitServiceDualStackMetricsState(svc),
+		DualStackMetricsState: metrics.InitServiceDualStackMetricsState(svc, &startTime),
 	}
 	return result
 }