Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE: respect static-ip assignment via update #26

Closed
bowei opened this issue Oct 11, 2017 · 3 comments
Closed

GCE: respect static-ip assignment via update #26

bowei opened this issue Oct 11, 2017 · 3 comments
Labels
backend/gce lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bowei
Copy link
Member

bowei commented Oct 11, 2017

From @bprashanth on January 31, 2017 23:4

Currently if you create an ingress then take its static-ip and assign the annotation, the controller is not smart enough to not delete the IP. To make this work:

  1. Gate Static IP cleanup on a call to getEffectiveIP(): https://github.com/kubernetes/ingress/blob/master/controllers/gce/loadbalancers/loadbalancers.go#L828 (just like we do here https://github.com/kubernetes/ingress/blob/master/controllers/gce/loadbalancers/loadbalancers.go#L548)
  2. Pipe the runtimeInfo into GC, instead of just the name (https://github.com/kubernetes/ingress/blob/master/controllers/gce/controller/controller.go#L324, https://github.com/kubernetes/ingress/blob/master/controllers/gce/controller/controller.go#L299)
  3. Store the updated runtimeInfo in the L7 struct (), before calling delete()

This way the call to getEffectiveIP will observe the annotation value right before deleting the IP

Copied from original issue: kubernetes/ingress-nginx#196

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 10, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/gce lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants