Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE: respect static-ip assignment via update #196

Closed
bprashanth opened this issue Jan 31, 2017 · 1 comment
Closed

GCE: respect static-ip assignment via update #196

bprashanth opened this issue Jan 31, 2017 · 1 comment

Comments

@bprashanth
Copy link
Contributor

Currently if you create an ingress then take its static-ip and assign the annotation, the controller is not smart enough to not delete the IP. To make this work:

  1. Gate Static IP cleanup on a call to getEffectiveIP(): https://github.com/kubernetes/ingress/blob/master/controllers/gce/loadbalancers/loadbalancers.go#L828 (just like we do here https://github.com/kubernetes/ingress/blob/master/controllers/gce/loadbalancers/loadbalancers.go#L548)
  2. Pipe the runtimeInfo into GC, instead of just the name (https://github.com/kubernetes/ingress/blob/master/controllers/gce/controller/controller.go#L324, https://github.com/kubernetes/ingress/blob/master/controllers/gce/controller/controller.go#L299)
  3. Store the updated runtimeInfo in the L7 struct (), before calling delete()

This way the call to getEffectiveIP will observe the annotation value right before deleting the IP

@bowei
Copy link
Member

bowei commented Oct 11, 2017

This issue was moved to kubernetes/ingress-gce#26

@bowei bowei closed this as completed Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants