Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress-GCE does not GC LB resources when ingress class changed and no other ingress on GCE exists #481

Closed
freehan opened this issue Sep 18, 2018 · 5 comments · Fixed by #547
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@freehan
Copy link
Contributor

freehan commented Sep 18, 2018

Repro steps:

  1. Make sure there is no ingress exists in the cluster.
  2. Create a test ingress with no ingress class annotation
  3. Wait for ingress-gce controller to provision LB
  4. Add a non-GCE ingress class on the test ingress
  5. The LB resources will be leaked.

Root cause:

@freehan freehan added the kind/bug Categorizes issue or PR as related to a bug. label Sep 18, 2018
@rramkumar1
Copy link
Contributor

/help-wanted
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@rramkumar1:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help-wanted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 30, 2018
@agadelshin
Copy link
Contributor

Hi! I'd like to take this.

@rramkumar1
Copy link
Contributor

@pondohva Thanks, send us a PR whenever you are ready!

/assign @pondohva

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: GitHub didn't allow me to assign the following users: pondohva.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

@pondohva Thanks, send us a PR whenever you are ready!

/assign @pondohva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants