Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackendConfig OpenAPI spec #563

Closed
DennisVis opened this issue Nov 29, 2018 · 13 comments
Closed

BackendConfig OpenAPI spec #563

DennisVis opened this issue Nov 29, 2018 · 13 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@DennisVis
Copy link

I'm using Deployment Manager to deploy all k8s resources by leveraging custom types. To create these types Deployment Manager needs access to an OpenAPI spec. For the Ingress this works fine, but I can't find the one for the BackendConfig type.

I see one is created in pkg/apis/backendconfig/v1beta1/zz_generated.openapi.go, is this exposed anywhere on the gke cluster?

@rramkumar1
Copy link
Contributor

@DennisVis when you say "can't find one for the BackendConfig type", can you point me to where you looked?

I remember in the past we have had some complaints that BackendConfig does not work with Deployment Manager so hopefully we can address that soon.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 29, 2018
@DennisVis
Copy link
Author

The first place I looked was in the cluster swagger specification which can be found at https://{cluster-ip}/swaggerapi. But none of the endpoints seem to hold a reference to the namespace being used by the BackendConfig cloud.google.com.

I tried finding the API itself which can be found at https://{cluster-ip}/apis/cloud.google.com/v1beta1. A GET request results in a descriptive document, but it's not an OpenAPI spec so DM can't use it.

I assume the spec must live somewhere and be reachable as the existence of zz_generated.openapi.go suggests as much.

@rramkumar1
Copy link
Contributor

@DennisVis thanks for the info. I'll ask around to see how this can be resolved as I'm not immediately sure what the next step is.

@DennisVis
Copy link
Author

@rramkumar1 Did you manage to make any progress on this?

@MrHohn
Copy link
Member

MrHohn commented Jan 9, 2019

It seems like folks are working on publishing openapi for CRD: kubernetes/kubernetes#71192

@mbohlool
Copy link

mbohlool commented Jan 9, 2019

Also https://{cluster-ip}/swaggerapi is deprecated and old swagger 1.2. It is not up to date. The correct path is https://{cluster-ip}/openapi/v2. But CRDs is not included in OpenAPI spec yet and kubernetes/kubernetes#71192 is trying to handle that. Note that it will only appear if the CRD has a validation schema which is in OpenAPI v3 model format (or schema field for new versions struct in CRD's spec.versions)

@bowei
Copy link
Member

bowei commented Jan 9, 2019

@rramkumar1 we should check if we satisfy the OpenAPI v3 model format and close this bug.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 10, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bowei bowei reopened this Jun 9, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants