Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for multi cluster ingresses #71

Closed
1 of 2 tasks
nikhiljindal opened this issue Nov 6, 2017 · 20 comments
Closed
1 of 2 tasks

Add tests for multi cluster ingresses #71

nikhiljindal opened this issue Nov 6, 2017 · 20 comments
Assignees
@nikhiljindal
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@nikhiljindal
Copy link
Contributor

nikhiljindal commented Nov 6, 2017 •
edited
Loading

Tasks:

  • Add an e2e test to ensure that instance groups annotation is added to an ingress with the multicluster ingress class annotation.
  • Ensure that the instance groups annotation is added for each zone in a multi zonal cluster.

cc @nicksardo @G-Harmon
@nikhiljindal
Copy link
Contributor Author

I have kubernetes/kubernetes#55047 for the first with a TODO for the second :)

@nicksardo Do you know if we have any ingress tests for multi-zone clusters?
I am not sure how much extra work it is to set up infra for multi zone clusters.
@bowei Is this something you are looking at as part of improving test coverage for ingress?

@nikhiljindal nikhiljindal mentioned this issue Nov 6, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Nov 7, 2017
Merge pull request #55047 from nikhiljindal/ingressTest
743d11f 
Automatic merge from submit-queue (batch tested with PRs 55093, 54966, 55047, 54971, 54786). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Adding an e2e test for gce multi cluster ingress

Basic test that verifies that multi cluster ingress gets the instance groups annotation.

Ref kubernetes/ingress-gce#71

cc @csbell @G-Harmon @nicksardo @bowei 

```release-note
NONE```
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2018
@nikhiljindal
Copy link
Contributor Author

/remove-lifecycle stale

cc @MrHohn do we have ingress tests for multi-zone clusters?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2018
@MrHohn
Copy link
Member

MrHohn commented Feb 7, 2018

cc @MrHohn do we have ingress tests for multi-zone clusters?

Not that I know of, I was also thinking of a test case that requires adding a new zone to the cluster. But not works have been done at this point.

@nikhiljindal
Copy link
Contributor Author

ok. Do you plan to add another job that brings up a multizone cluster and then run (all or some selected) existing tests?
Or add a zone to a cluster as part of the existing e2e test job?

@MrHohn
Copy link
Member

MrHohn commented Feb 7, 2018

Do you plan to add another job that brings up a multizone cluster and then run (all or some selected) existing tests?
Or add a zone to a cluster as part of the existing e2e test job?

I was thinking about the second case --- adding a zone to a cluster, but it seems like the fist case is something we should add first. I maybe able to take a look later if no ones plan to work on that.

@nikhiljindal
Copy link
Contributor Author

Sounds great!
Yes doing first will enable us to run existing tests in multicluster setup which will be a huge benefit.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2018
@G-Harmon
Copy link
Contributor

G-Harmon commented May 8, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2018
@nikhiljindal
Copy link
Contributor Author

@MrHohn Any update on multi-zonal cluster support for testing ingresses?

@G-Harmon
Copy link
Contributor

G-Harmon commented Aug 7, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2018
@MrHohn
Copy link
Member

MrHohn commented Aug 7, 2018

@nikhiljindal Sorry this fell off the radar. I will see if I can do something this week.

@bowei
Copy link
Member

bowei commented Aug 7, 2018

zihong is filing a separate issue for tracking adding multi-zonal tests

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2018
@rramkumar1
Copy link
Contributor

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 30, 2018
@rramkumar1
Copy link
Contributor

@nikhiljindal We just added a new test job which runs against a multi-zonal cluster.

See https://k8s-testgrid.appspot.com/sig-network-ingress-gce-e2e#ingress-gce-e2e-multi-zone

So you should be able to now modify the existing e2e test to check that the annotation has been added for each zone. The code to get the cluster zones can be found at https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/util.go#L5245:6

@rramkumar1
Copy link
Contributor

/assign @nikhiljindal

@rramkumar1
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhiljindal nikhiljindal

Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@bowei @MrHohn @nikhiljindal @k8s-ci-robot @rramkumar1 @fejta-bot @G-Harmon