Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or verify the GC logic for multi-cluster ingress #836

Closed
MrHohn opened this issue Aug 28, 2019 · 1 comment · Fixed by #838
Closed

Fix or verify the GC logic for multi-cluster ingress #836

MrHohn opened this issue Aug 28, 2019 · 1 comment · Fixed by #838

Comments

@MrHohn
Copy link
Member

MrHohn commented Aug 28, 2019

Ref #825 (comment), we may have broke the GC logic for multi-cluster ingress --- we need to keep the instance group if we have at least one multi-cluster ingress. The current logic may delete the instance group if there isn't any gce ingresses (regardless of multi-cluster ingress).

(By multi-cluster ingress I meant below)

// IsGCEMultiClusterIngress returns true if the given Ingress has
// ingress.class annotation set to "gce-multi-cluster".
func IsGCEMultiClusterIngress(ing *v1beta1.Ingress) bool {
class := annotations.FromIngress(ing).IngressClass()
return class == annotations.GceMultiIngressClass
}

/assign @skmatti

@k8s-ci-robot
Copy link
Contributor

@MrHohn: GitHub didn't allow me to assign the following users: skmatti.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Ref #825 (comment), we may have broke the GC logic for multi-cluster ingress --- we need to keep the instance group if we have at least one multi-cluster ingress. The current logic may delete the instance group if there isn't any gce ingresses (regardless of multi-cluster ingress).

(By multi-cluster ingress I meant below)

// IsGCEMultiClusterIngress returns true if the given Ingress has
// ingress.class annotation set to "gce-multi-cluster".
func IsGCEMultiClusterIngress(ing *v1beta1.Ingress) bool {
class := annotations.FromIngress(ing).IngressClass()
return class == annotations.GceMultiIngressClass
}

/assign @skmatti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants