Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test case TestBasicWindows #1006

Merged
merged 1 commit into from
Feb 4, 2020
Merged

added test case TestBasicWindows #1006

merged 1 commit into from
Feb 4, 2020

Conversation

yliaog
Copy link
Contributor

@yliaog yliaog commented Jan 24, 2020 •
edited
Loading

added test case TestBasicWindows that tests basic ingress for windows sever

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin January 24, 2020 22:22
@yliaog
Copy link
Contributor Author

yliaog commented Jan 24, 2020

/assign @rramkumar1

@bowei
Copy link
Member

bowei commented Jan 27, 2020

Wondering if this should be a separate test case that runs a check on a windows node if one exists on the cluster.
I would like to avoid having to maintain specific OS flags on the test executable.

@yliaog
Copy link
Contributor Author

yliaog commented Jan 27, 2020

For windows, the backend service pod container image has to be built to run on windows, and it needs to be scheduled to run on windows.

the test cases are the same for windows and for linux.

@yliaog
Copy link
Contributor Author

yliaog commented Jan 29, 2020

@rramkumar1 ping ...

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2020
@yliaog yliaog changed the title added support for running backend on windows server node added test case TestBasicWindows Jan 30, 2020
@yliaog yliaog force-pushed the master branch 3 times, most recently from b857e11 to 8aa304c Compare January 30, 2020 20:34
@yliaog
Copy link
Contributor Author

yliaog commented Jan 30, 2020

@bowei PTAL

@yliaog
Copy link
Contributor Author

yliaog commented Jan 31, 2020

@bowei
friendly ping ...

rramkumar1
rramkumar1 reviewed Jan 31, 2020
View reviewed changes
pkg/e2e/fixtures.go Show resolved Hide resolved
cmd/e2e-test/basic_test.go Outdated
@@ -29,7 +29,15 @@ import (
"k8s.io/ingress-gce/pkg/utils/common"
)

func TestBasicWindows(t *testing.T) {
testBasicOS(t, "windows")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the const iota pattern here rather than passing in a raw string? So just define a type called "OS" and then have two values for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, changed, PTAL

rramkumar1
rramkumar1 reviewed Feb 3, 2020
View reviewed changes
pkg/e2e/fixtures.go Outdated Show resolved Hide resolved
rramkumar1
rramkumar1 reviewed Feb 3, 2020
View reviewed changes
pkg/e2e/fixtures.go Outdated Show resolved Hide resolved
rramkumar1
rramkumar1 reviewed Feb 4, 2020
View reviewed changes
cmd/e2e-test/basic_test.go Outdated
@@ -29,7 +29,15 @@ import (
"k8s.io/ingress-gce/pkg/utils/common"
)

func TestBasicWindows(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call you call this TestWindows instead.

rramkumar1
rramkumar1 reviewed Feb 4, 2020
View reviewed changes
pkg/e2e/fixtures.go Outdated Show resolved Hide resolved
rramkumar1
rramkumar1 reviewed Feb 4, 2020
View reviewed changes
pkg/e2e/fixtures.go Outdated Show resolved Hide resolved
pkg/e2e/fixtures.go Outdated Show resolved Hide resolved
@rramkumar1
Copy link
Contributor

@yliaog Last comments above, then LGTM.

@yliaog yliaog force-pushed the master branch 2 times, most recently from ffcd0d2 to 3cdd8a2 Compare February 4, 2020 21:47
@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rramkumar1, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1508e80 into kubernetes:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yliaog @bowei @rramkumar1 @k8s-ci-robot