Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set healthcheck from BackendConfig #1029

Merged
merged 4 commits into from
Feb 23, 2020
Merged

Set healthcheck from BackendConfig #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb5edf1
Add support for nil to HTTPStatusCode
bowei Feb 17, 2020
5813134
Take healthcheck configuration overrides from the backendconfig
bowei Feb 17, 2020
13844f7
Add testing for `SyncServicePort`
bowei Feb 17, 2020
168a7bc
Update code generation (was missing healthcheck fields)
bowei Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@ k8s.io/component-base v0.17.0 h1:BnDFcmBDq+RPpxXjmuYnZXb59XNN9CaFrX8ba9+3xrA=
k8s.io/component-base v0.17.0/go.mod h1:rKuRAokNMY2nn2A6LP/MiwpoaMRHpfRnrPaUJJj1Yoc=
k8s.io/cri-api v0.0.0-20190531030430-6117653b35f1/go.mod h1:K6Ux7uDbzKhacgqW0OJg3rjXk/SR9kprCPfSUDXGB5A=
k8s.io/csi-translation-lib v0.0.0-20190620090114-816aa063c73d/go.mod h1:q5k0Vv3qsOTu2PUrTh+4mRAj+Pt+1BRyWiiwr5LBFOM=
k8s.io/gengo v0.0.0-20190116091435-f8a0810f38af h1:SwjZbO0u5ZuaV6TRMWOGB40iaycX8sbdMQHtjNZ19dk=
k8s.io/gengo v0.0.0-20190116091435-f8a0810f38af/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
k8s.io/gengo v0.0.0-20190128074634-0689ccc1d7d6/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
k8s.io/heapster v1.2.0-beta.1/go.mod h1:h1uhptVXMwC8xtZBYsPXKVi8fpdlYkTs6k949KozGrM=
Expand Down
26 changes: 19 additions & 7 deletions pkg/apis/backendconfig/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,23 @@ type CustomRequestHeadersConfig struct {
// HealthCheckConfig contains configuration for the health check.
// +k8s:openapi-gen=true
type HealthCheckConfig struct {
CheckIntervalSec *int64 `json:"checkIntervalSec,omitempty"`
TimeoutSec *int64 `json:"timeoutSec,omitempty"`
HealthyThreshold *int64 `json:"healthyThreshold,omitempty"`
UnhealthyThreshold *int64 `json:"unhealthyThreshold,omitempty"`
Type *string `json:"type,omitempty"`
Port *int64 `json:"port,omitempty"`
RequestPath *string `json:"requestPath,omitempty"`
// CheckIntervalSec is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
CheckIntervalSec *int64 `json:"checkIntervalSec,omitempty"`
// TimeoutSec is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
TimeoutSec *int64 `json:"timeoutSec,omitempty"`
// HealthyThreshold is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
HealthyThreshold *int64 `json:"healthyThreshold,omitempty"`
// UnhealthyThreshold is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
UnhealthyThreshold *int64 `json:"unhealthyThreshold,omitempty"`
// Type is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
Type *string `json:"type,omitempty"`
Port *int64 `json:"port,omitempty"`
// RequestPath is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
RequestPath *string `json:"requestPath,omitempty"`
}
69 changes: 68 additions & 1 deletion pkg/apis/backendconfig/v1/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 19 additions & 7 deletions pkg/apis/backendconfig/v1beta1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,23 @@ type CustomRequestHeadersConfig struct {
// HealthCheckConfig contains configuration for the health check.
// +k8s:openapi-gen=true
type HealthCheckConfig struct {
CheckIntervalSec *int64 `json:"checkIntervalSec,omitempty"`
TimeoutSec *int64 `json:"timeoutSec,omitempty"`
HealthyThreshold *int64 `json:"healthyThreshold,omitempty"`
UnhealthyThreshold *int64 `json:"unhealthyThreshold,omitempty"`
Type *string `json:"type,omitempty"`
Port *int64 `json:"port,omitempty"`
RequestPath *string `json:"requestPath,omitempty"`
// CheckIntervalSec is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
CheckIntervalSec *int64 `json:"checkIntervalSec,omitempty"`
// TimeoutSec is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
TimeoutSec *int64 `json:"timeoutSec,omitempty"`
// HealthyThreshold is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
HealthyThreshold *int64 `json:"healthyThreshold,omitempty"`
// UnhealthyThreshold is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
UnhealthyThreshold *int64 `json:"unhealthyThreshold,omitempty"`
// Type is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
Type *string `json:"type,omitempty"`
Port *int64 `json:"port,omitempty"`
// RequestPath is a health check parameter. See
// https://cloud.google.com/compute/docs/reference/rest/v1/healthChecks.
RequestPath *string `json:"requestPath,omitempty"`
}
69 changes: 68 additions & 1 deletion pkg/apis/backendconfig/v1beta1/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading