Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Access Logs in BackendConfig #1041

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Add support for Access Logs in BackendConfig #1041

merged 2 commits into from
Mar 12, 2020

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Feb 25, 2020 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 25, 2020
@skmatti
Copy link
Contributor Author

skmatti commented Feb 25, 2020

/assign @minhan @bowei

@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn February 25, 2020 23:55
@k8s-ci-robot
Copy link
Contributor

@skmatti: GitHub didn't allow me to assign the following users: minhan.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @minhan @bowei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skmatti
Copy link
Contributor Author

skmatti commented Feb 25, 2020

/assign @freehan

@bowei
Copy link
Member

bowei commented Feb 26, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2020
@freehan
Copy link
Contributor

freehan commented Feb 28, 2020

Is this still needed?

@skmatti
Copy link
Contributor Author

skmatti commented Feb 28, 2020

Yes, this will go into v1.9.0. Older versions do not need this as a feature. But, starting v1.9.0, users can configure access logs as they like.

@skmatti skmatti force-pushed the be-logs-api-impl branch from f61d048 to bf6d153 Compare March 1, 2020 06:30
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 1, 2020
@skmatti skmatti force-pushed the be-logs-api-impl branch from bf6d153 to 5b3a72f Compare March 1, 2020 07:36
@skmatti skmatti force-pushed the be-logs-api-impl branch from 5b3a72f to fde6725 Compare March 5, 2020 22:34
freehan
freehan reviewed Mar 9, 2020
View reviewed changes
pkg/backends/features/logging.go
logConfig := &composite.BackendServiceLogConfig{
Enable: sp.BackendConfig.Spec.Logging.Enable,
}
if !sp.BackendConfig.Spec.Logging.Enable || sp.BackendConfig.Spec.Logging.SampleRate == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to check if Logging is nil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is checked in caller function. Added a comment that this is assumed to be not nil. Would it be cleaner if I explicitly include a check here as well?.

@skmatti skmatti force-pushed the be-logs-api-impl branch from fde6725 to 662b08c Compare March 9, 2020 21:13
@skmatti skmatti force-pushed the be-logs-api-impl branch from 662b08c to 7fcf338 Compare March 9, 2020 21:27
freehan
freehan approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit fbc1bf9 into kubernetes:master Mar 12, 2020
k8s-ci-robot added a commit that referenced this pull request Mar 13, 2020
@k8s-ci-robot
Merge pull request #1056 from skmatti/be-logs-impl-1.9
5a33c28 
Cherrypick #1041[Add support for Access Logs in BackendConfig] into release-1.9
@skmatti skmatti deleted the be-logs-api-impl branch March 13, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan approved these changes

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@bowei bowei

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skmatti @k8s-ci-robot @bowei @freehan