Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backendconfig v1 for e2e tests #1045

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Use backendconfig v1 for e2e tests #1045

merged 3 commits into from
Apr 7, 2020

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Mar 1, 2020

  • Existing e2e tests are migrated to use backendconfig v1
  • one e2e test for backendconfig v1beta1 API is added

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from freehan and thockin March 1, 2020 07:32
@freehan
Copy link
Contributor

freehan commented Mar 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2020
@skmatti
Copy link
Contributor Author

skmatti commented Mar 25, 2020

/assign @freehan

freehan
freehan reviewed Mar 30, 2020
View reviewed changes
cmd/e2e-test/affinity_beta_test.go Outdated
func TestAffinityBeta(t *testing.T) {
t.Parallel()

for _, tc := range []struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if it is worth merging test cases into one transition test together. Meaning that each test case becomes a state/expectation. The test would go thru each test case, trigger a transition and verify if the final state is expected.

Then there is no need to create separate ingress for each test case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline that we should keep beta tests in a separate file for simplicity.

Consolidated affinity transitions to use a single ingress as suggested.

@skmatti skmatti force-pushed the beconfig-ga-e2e branch 2 times, most recently from d29b4a3 to f7a75ec Compare March 31, 2020 01:17
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2020
freehan
freehan approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type conversion is a bit fragile. But assuming v1 always have more fields than beta. Plus this only used for test. It is good enough.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 24c091f into kubernetes:master Apr 7, 2020
@skmatti skmatti deleted the beconfig-ga-e2e branch May 12, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan approved these changes

@thockin thockin Awaiting requested review from thockin

Assignees

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skmatti @k8s-ci-robot @freehan