Revert #849[Use protobufs for communication with apiserver] in v1.6 #1050

skmatti · 2020-03-11T06:47:36Z

k8s-ci-robot · 2020-03-11T06:47:44Z

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

skmatti · 2020-03-11T06:47:56Z

/assign @freehan @bowei

bowei · 2020-03-11T16:57:39Z

cmd/glbc/app/clients.go

+// KubeConfigForProtobuf returns a shallow copy of client config after updating
+// content type to protobuf.
+func KubeConfigForProtobuf(kubeConfig *rest.Config) *rest.Config {
+	configShallowCopy := *kubeConfig


why not deep copy?

We are modifying only the top level variable and this is used as read only by kubeclient for most part. I modified this to create separate configurations in each case.

bowei · 2020-03-11T16:58:35Z

pkg/controller/controller.go

 			ings := operator.Ingresses(ctx.Ingresses().List()).ReferencesBackendConfig(beConfig, operator.Services(ctx.Services().List())).AsList()
+			if len(ings) == 0 {


I think Enqueue already logs?

Not when ingresses are not enqueued(empty slice). I preserved this log and removed the other.

can we make Enqueue log for empty slice and delete the extra logs outside the call

Removed these logs. Not sure adding this log inside enqueue would be any help as this backendconfig obj is not available inside that method.

bowei · 2020-03-11T16:58:43Z

pkg/controller/controller.go

 				ings := operator.Ingresses(ctx.Ingresses().List()).ReferencesBackendConfig(beConfig, operator.Services(ctx.Services().List())).AsList()
+				if len(ings) == 0 {


pkg/controller/controller.go

bowei · 2020-03-11T17:00:57Z

pkg/controller/controller.go

 			ings := operator.Ingresses(ctx.Ingresses().List()).ReferencesBackendConfig(beConfig, operator.Services(ctx.Services().List())).AsList()
+			if len(ings) == 0 {


again, check that we log in Enqueue so we don't have to log here as well

bowei · 2020-03-11T17:31:52Z

/ok-to-test

freehan · 2020-03-11T17:53:58Z

Discussed offline. @skmatti will rollback the protobuf PR for ingress 1.6 as for now.

Fix will be pushed to HEAD and cherrypick back to 1.6 1.7

skmatti · 2020-03-11T17:57:43Z

Discussed offline. @skmatti will rollback the protobuf PR for ingress 1.6 as for now.

Fix will be pushed to HEAD and cherrypick back to 1.6 1.7

Rolled back #849 in v1.6. I think this more cleaner as this change never got released in any GKE versions.

bowei · 2020-03-11T18:03:25Z

/lgtm
/approve

k8s-ci-robot · 2020-03-11T18:03:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bowei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2020

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2020

k8s-ci-robot assigned bowei and freehan Mar 11, 2020

k8s-ci-robot requested review from bowei and thockin March 11, 2020 06:48