-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FrontendConfig v1beta1 API so that Spec and Status fields are optional #1082
Update FrontendConfig v1beta1 API so that Spec and Status fields are optional #1082
Conversation
…omitempty This matches the same behavior of the BackendConfig CRD
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this all of the generated files? |
@bowei Yes that's everything that the hack/ script updated |
Cherry-pick #1082 to release-1.9 [Update FrontendConfig v1beta1 API so that Spec and Status fields are omitempty]
This matches the same behavior of the BackendConfig CRD
This will also need to be cherry picked into v1.9
/assign @bowei