-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rbac permissions for networking.gke.io/frontendconfigs #1128
Add rbac permissions for networking.gke.io/frontendconfigs #1128
Conversation
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @freehan |
is there an e2e test? How do we catch this next time? /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @bowei! Any e2e test using a new CRD will catch this in a real cluster. The issue is that you won't see this if you run the binary locally (--running-in-cluster=false). As far as catching this earlier, I'm not sure what else to do besides potentially writing a quick guide for adding new CRDs. |
Cherry-pick #1128 to release-1.9 [Add rbac permissions for networking.gke.io/frontendconfigs]
This will need to be cherry-picked into release-1.9 asap
Tested the rbac config in a sandbox