Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set -logtostderr (this matches the original behavior) #119

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

bowei
Copy link
Member

@bowei bowei commented Jan 30, 2018

We will remove this when a release can be cut to support logging to
stderr.

We will remove this when a release can be cut to support logging to
stderr.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2018
@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2018
@nicksardo nicksardo merged commit 4bf810e into kubernetes:master Jan 30, 2018
@k8s-ci-robot
Copy link
Contributor

@bowei: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-gce-test 5f2e432 link /test pull-ingress-gce-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bowei bowei deleted the logtostderr branch June 10, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants