Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #1209 [Expose custom health check ports in the firewall] into release-1-9 #1220

Merged

Conversation

spencerhance
Copy link
Contributor

Also includes the commit from #1084 in order to cherry-pick in the e2e tests as well

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2020
@spencerhance
Copy link
Contributor Author

/assign @rramkumar1

@rramkumar1
Copy link
Contributor

@spencerhance Let's keep the cherry pick clean. Can you send a separate PR for the test.

@spencerhance
Copy link
Contributor Author

@rramkumar1 Sure thing. Should I just include 007bf05 and not include 54885c3 from the original PR?

@rramkumar1
Copy link
Contributor

The cherrypick should only contain the same commits from the corresponding PR which was merged to HEAD.

@spencerhance
Copy link
Contributor Author

Hmm okay. I don't see a reasonable way to cherry-pick both commits from #1209 without including bowei's e2e stuff. I can just cherry-pick 007bf05 and not include the other commit in this PR.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2020
@rramkumar1
Copy link
Contributor

/lgtm

@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rramkumar1, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 11f4c48 into kubernetes:release-1.9 Aug 20, 2020
@spencerhance spencerhance deleted the cp-1209-release-1-9 branch August 20, 2020 17:47
@spencerhance spencerhance restored the cp-1209-release-1-9 branch September 24, 2020 21:49
@spencerhance spencerhance deleted the cp-1209-release-1-9 branch October 24, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants