-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #1209 [Expose custom health check ports in the firewall] into release-1-9 #1220
Cherry-pick #1209 [Expose custom health check ports in the firewall] into release-1-9 #1220
Conversation
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rramkumar1 |
@spencerhance Let's keep the cherry pick clean. Can you send a separate PR for the test. |
@rramkumar1 Sure thing. Should I just include 007bf05 and not include 54885c3 from the original PR? |
The cherrypick should only contain the same commits from the corresponding PR which was merged to HEAD. |
54885c3
to
007bf05
Compare
/lgtm |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rramkumar1, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also includes the commit from #1084 in order to cherry-pick in the e2e tests as well