Trigger sync for certain node changes #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
freehan
reviewed
Nov 5, 2021
prameshj
reviewed
Nov 5, 2021
swetharepakula
force-pushed
the
zone-change
branch
3 times, most recently
from
73df9f0 to
05d9035
Compare
prameshj
reviewed
Nov 9, 2021
freehan
reviewed
Nov 9, 2021
* VmIpPort NEGs should be synced when node change results in a zone being added or removed * Node informer event handlers are initialized in all cases
swetharepakula
force-pushed
the
zone-change
branch
from
05d9035 to
0141ba1
Compare
|
Looks good overall. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prameshj, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Nov 10, 2021
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 10, 2021
[Cherrypick #1600 into 1.13] Trigger sync for certain node changes
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 10, 2021
[Cherrypick #1600 into 1.12] Zone change 1.12
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 10, 2021
[Cherrypick #1600 into 1.11] Trigger sync for certain node changes
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 13, 2021
[Cherrypick #1600 to 1.14] Trigger sync for certain node changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
being added or removed
/assign @freehan @prameshj